Skip to content

nocontrold: Eliminating ocfs2_controld

Goldwyn Rodrigues ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 6 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/6] nocontrold: Eliminating ocfs2_controld

Hi Mark,

Thanks for the review so far. I was on vacation and could not get back to this earlier.

Quoted 25 lines · Mark Fasheh
Quoted 24 lines · Goldwyn Rodrigues

Hi Lars,

Quoted 21 lines · Lars Marowsky-Bree

On 2013-09-05T22:26:56, Goldwyn Rodrigues <[email protected]> wrote:

Hi Goldwyn,

thanks! This looks really good.

Quoted 4 lines

This is an effort of removing ocfs2_controld.pcmk and getting ocfs2 DLM handling up to the times with respect to DLM (>=4.0.1) and corosync (2.3.x). AFAIK, cman also is being phased out for a unified corosync cluster stack.

That's clearly necessary, also to bring OCFS2 more uptodate with the latest happenings in the GFS2 world; it'll allow both file systems to share exactly the same cluster stack.

Quoted 3 lines

https://github.com/goldwynr/ocfs2-tools branch: nocontrold Currently, not many checks are present in the userspace code, but that would change soon.

There's one question I have; how will this handle

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

- the "old" user-space code starting on a new kernel,

The ocfs2_controld.pcmk will refuse to start because of absence of the control device created by the kernel. Of course, this would deny mounts as well.

Do we know how the GFS2 project handled this case? It's going to be a major problem for people if a kernel update horks their cluster fs.

Okay, I have managed to work on this and can mount filesystems which are used with ocfs2_controld. So, we have backward compatibility.

The only downside is we will not have a code reduction :( I will post the patches soon for review.

Quoted 9 lines
Quoted 9 lines
Quoted 4 lines

Is there anything we can do to at least provide a meaningful error message in the first case? The second should be easier to handle.

Yes, we can capture the error code and ask the user to upgrade in the second case. However, for the first case mount.ocfs2 would give a cluster connect failure because ocfs2_controld is not present.

Quoted 5 lines
Quoted 3 lines

On a different note, we should consider increasing the kernel module version shown in dmesg to be in sync with the userspace tools and/or possibly increase the version number of both tools and kernel module.

That shouldn't be a problem, the numbers are mostly there for us Ocfs2 devs.

Understood. I hope the devs at Oracle does too :) especially from the tools POV.

Signature · 1 line
Goldwyn