Skip to content

Arrange hotpluggable memory as ZONE_MOVABLE

Zhang Yanfei linux-mm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/28 patches 14 repliesIn review
  2. v2 posting 1/28 patches 17 repliesSuperseded
  3. v18 patches 0 repliesSuperseded

Changes in v2 from the cover letter

1. Rebase this part on the v7 version of part1
2. Fix bug: If movable_node boot option not specified, memblock still checks hotpluggable memory when allocating memory.

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8x86: get pg_data_t's memory from other nodearch/x86/mm/numa.c+8 -38 replies
2/8memblock, numa: Introduce flag into memblockinclude/linux/memblock.h mm/memblock.c+39 -150 replies
3/8memblock, mem_hotplug: Introduce MEMBLOCK_HOTPLUG flag to mark hotpluggable regionsinclude/linux/memblock.h mm/memblock.c+69 -00 replies
4/8memblock: Make memblock_set_node() support different memblock_typearch/metag/mm/init.c arch/metag/mm/numa.c arch/microblaze/mm/init.c +9 more+28 -190 replies
5/8acpi, numa, mem_hotplug: Mark hotpluggable memory in memblockarch/x86/mm/numa.c arch/x86/mm/srat.c+7 -00 replies
6/8acpi, numa, mem_hotplug: Mark all nodes the kernel resides un-hotpluggablearch/x86/mm/numa.c+44 -01 reply
6/8acpi, numa, mem_hotplug: Mark all nodes the kernel resides un-hotpluggablearch/x86/mm/numa.c+45 -00 replies
7/8memblock, mem_hotplug: Make memblock skip hotpluggable regions if neededinclude/linux/memblock.h mm/memblock.c mm/memory_hotplug.c+31 -00 replies
8/8x86, numa, acpi, memory-hotplug: Make movable_node have higher prioritymm/page_alloc.c+26 -21 reply

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchWanpeng LiToshi KaniZhang Yanfei
1/8R-b A-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b R-b
6/8R-b R-b
7/8
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH RESEND part2 v2 0/8] Arrange hotpluggable memory as ZONE_MOVABLE

[Problem]

The current Linux cannot migrate pages used by the kerenl because of the kernel direct mapping. In Linux kernel space, va = pa + PAGE_OFFSET. When the pa is changed, we cannot simply update the pagetable and keep the va unmodified. So the kernel pages are not migratable.

There are also some other issues will cause the kernel pages not migratable. For example, the physical address may be cached somewhere and will be used. It is not to update all the caches.

When doing memory hotplug in Linux, we first migrate all the pages in one memory device somewhere else, and then remove the device. But if pages are used by the kernel, they are not migratable. As a result, memory used by the kernel cannot be hot-removed.

Modifying the kernel direct mapping mechanism is too difficult to do. And it may cause the kernel performance down and unstable. So we use the following way to do memory hotplug.

[What we are doing]

In Linux, memory in one numa node is divided into several zones. One of the zones is ZONE_MOVABLE, which the kernel won't use.

In order to implement memory hotplug in Linux, we are going to arrange all hotpluggable memory in ZONE_MOVABLE so that the kernel won't use these memory.

To do this, we need ACPI's help.

[How we do this]

In ACPI, SRAT(System Resource Affinity Table) contains NUMA info. The memory affinities in SRAT record every memory range in the system, and also, flags specifying if the memory range is hotpluggable.
(Please refer to ACPI spec 5.0 5.2.16)

With the help of SRAT, we have to do the following two things to achieve our goal:

1. When doing memory hot-add, allow the users arranging hotpluggable as ZONE_MOVABLE.
(This has been done by the MOVABLE_NODE functionality in Linux.)

2. when the system is booting, prevent bootmem allocator from allocating hotpluggable memory for the kernel before the memory initialization finishes.
(This is what we are going to do. See below.)

[About this patch-set]

In previous part's patches, we have made the kernel allocate memory near kernel image before SRAT parsed to avoid allocating hotpluggable memory for kernel. So this patch-set does the following things:

1. Improve memblock to support flags, which are used to indicate different memory type.

2. Mark all hotpluggable memory in memblock.memory[].

3. Make the default memblock allocator skip hotpluggable memory.

4. Improve "movable_node" boot option to have higher priority of movablecore and kernelcore boot option.

Change log v1 -> v2:
1. Rebase this part on the v7 version of part1
2. Fix bug: If movable_node boot option not specified, memblock still checks hotpluggable memory when allocating memory.

Tang Chen (7):
memblock, numa: Introduce flag into memblock
memblock, mem_hotplug: Introduce MEMBLOCK_HOTPLUG flag to mark
hotpluggable regions
memblock: Make memblock_set_node() support different memblock_type acpi, numa, mem_hotplug: Mark hotpluggable memory in memblock acpi, numa, mem_hotplug: Mark all nodes the kernel resides
un-hotpluggable
memblock, mem_hotplug: Make memblock skip hotpluggable regions if
needed
x86, numa, acpi, memory-hotplug: Make movable_node have higher
priority

Yasuaki Ishimatsu (1):
x86: get pg_data_t's memory from other node

 arch/metag/mm/init.c      |    3 +-
 arch/metag/mm/numa.c      |    3 +-
 arch/microblaze/mm/init.c |    3 +-
 arch/powerpc/mm/mem.c     |    2 +-
 arch/powerpc/mm/numa.c    |    8 ++-
 arch/sh/kernel/setup.c    |    4 +-
 arch/sparc/mm/init_64.c   |    5 +-
 arch/x86/mm/init_32.c     |    2 +-
 arch/x86/mm/init_64.c     |    2 +-
 arch/x86/mm/numa.c        |   63 +++++++++++++++++++++--
 arch/x86/mm/srat.c        |    5 ++
 include/linux/memblock.h  |   39 ++++++++++++++-
 mm/memblock.c             |  123 ++++++++++++++++++++++++++++++++++++++-------
 mm/memory_hotplug.c       |    1 +
 mm/page_alloc.c           |   28 ++++++++++-
 15 files changed, 252 insertions(+), 39 deletions(-)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>