Skip to content

arm, arm64: check for number of arguments in syscall_get/set_arguments()

AKASHI Takahiro linux-arm-kernel lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v11 patch 0 repliesSuperseded

Changes from the cover letter

* added a patch to arm as well
* added a patch to asm-generic/syscall.h; corrected the description on syscall_get_arguments() and syscall_put_arguments()
* removed portion of commit message which referred to asm-generic/syscall.h in arm64

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3arm64: check for number of arguments in syscall_get/set_arguments()arch/arm64/include/asm/syscall.h+6 -01 reply
2/3arm: check for number of arguments in syscall_get/set_arguments()arch/arm/include/asm/syscall.h+6 -01 reply
3/3asm-generic: syscall_get/set_arguments accept zero for number of argumentsinclude/asm-generic/syscall.h+2 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchWill Deacon
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] arm, arm64: check for number of arguments in syscall_get/set_arguments()
# added Roland <mcgrathr@chromium> in CC for asm-generic/syscall.h

I modified my patch based on Will's comments.
Speaking of arm, i + n is checked against SYSCALL_MAX_ARGS (== 7), but it seems that the kernel code assumes that the current max number of arguments would be 6. For example, SYSCALL_DEFINEn are defined from 0 to 6. Am i wrong?

Changes:
* added a patch to arm as well
* added a patch to asm-generic/syscall.h; corrected the description on syscall_get_arguments() and syscall_put_arguments()
* removed portion of commit message which referred to asm-generic/syscall.h in arm64

AKASHI Takahiro (3):
arm64: check for number of arguments in syscall_get/set_arguments()
arm: check for number of arguments in syscall_get/set_arguments()
asm-generic: syscall_get/set_arguments accept zero for number of
arguments

 arch/arm/include/asm/syscall.h   |    6 ++++++
 arch/arm64/include/asm/syscall.h |    6 ++++++
 include/asm-generic/syscall.h    |    4 ++--
 3 files changed, 14 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.9.5