Skip to content

fix MVEBU GPIO driver bug causing kernel hang

Gerlando Falauto linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 1 patch 0 repliesNew

Patches in v1 No applies recorded yet

The patch the cover letter announces is not in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] fix MVEBU GPIO driver bug causing kernel hang

Hi Thomas,

Quoted 8 lines · Thomas Petazzoni

Dear Gerlando Falauto,

Quoted 3 lines · Gerlando Falauto

SIDE NOTE: If I understand correctly, a brand new driver from Sebastian Hesselbarth (drivers/irqchip/irq-orion.c) may replace this driver in the future, but it still misses the IRQ_GC_MASK_CACHE_PER_TYPE bit:

Quoted 6 lines

Hum? The driver you're touching is a GPIO driver, while drivers/irqchip/irq-orion.c is an interrupt controller driver. The gpio-mvebu driver can be used on all mvebu platforms that are DT capable, but the main interrupt controller is different from one platform to another: we already have irq-armada-370-xp.c for Armada 370/XP, while Sebastian's irq-orion.c is for older families of SoCs.

My foreword was "if I understand correctly", which I clearly didn't. ;-)

OK, so Sebastian's rework irq-orion.c is about the MAIN interrupt controller (replaces arch/arm/plat-orion/irq.c), which also cascades interrupts from GPIOs.
These are then either handled by gpio-mvebu.c (for all platforms which are DT capable) or by arch/arm/plat-orion/gpio.c (legacy). Is that right?

Quoted 1 line

Or maybe I'm missing something?

Sorry, I'm the one missing something here... perhaps too much.

Thanks!
Gerlando