Skip to content

nocontrold: Eliminating ocfs2_controld v3

Goldwyn Rodrigues ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 5 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/5] nocontrold: Eliminating ocfs2_controld v3
Quoted 4 lines · Lars Marowsky-Bree

On 2013-10-03T00:48:55, Goldwyn Rodrigues <[email protected]> wrote:

Hi Goldwyn,

Quoted 8 lines

just a minor comment:

Quoted 2 lines

For backward compatibility, we are keeping the controld handling code. Once enough time has passed we can remove a significant portion of the code.

Can we add this to Documentation/fs/ocfs2.txt, or maybe print a one-time message on activating the deprecated mode with an intended removal date? (I'd propose end-of-2014.)

We already print a message in dmesg saying:
printk(KERN_NOTICE "ocfs2: You seem to be using an older "
"version of dlm_controld and/or ocfs2-tools." " Please consider upgrading.\n");

Adding a date to this should not be a problem.

Quoted 4 lines

And, perhaps, a compile-time option to disable this earlier, so that users can choose the stacks they want to build the kernel with.

This would a be a couple of ifdef's in user_cluster_connect(). What do other ocfs2 developers feel about this?

Signature · 1 line
Goldwyn