Skip to content

target-ppc: PowerPC VSX Stage 3

Tom Musta qemu-devel 5 versions – Applied

Status from this message: Thanks applied all to ppc-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest22 patches 3 repliesApplied
  2. v422 patches 8 repliesSuperseded
  3. v319 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v219 patches1 replySuperseded
v119 patches38 repliesSuperseded

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/22softfloat: Fix float64_to_uint64fpu/softfloat.c+94 -91 reply
2/22softfloat: Add float32_to_uint64()fpu/softfloat.c include/fpu/softfloat.h+47 -01 reply
3/22softfloat: Fix float64_to_uint64_round_to_zerofpu/softfloat.c+5 -70 replies
4/22softfloat: Fix float64_to_uint32fpu/softfloat.c+7 -80 replies
5/22softfloat: Fix float64_to_uint32_round_to_zerofpu/softfloat.c+7 -80 replies
6/22target-ppc: Add set_fprf Argument to fload_invalid_op_excp()target-ppc/fpu_helper.c+55 -480 replies
7/22target-ppc: General Support for VSX Helperstarget-ppc/fpu_helper.c target-ppc/translate.c+55 -00 replies
8/22target-ppc: Add VSX ISA2.06 xadd/xsub Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+78 -00 replies
9/22target-ppc: Add VSX ISA2.06 xmul Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+55 -00 replies
10/22target-ppc: Add VSX ISA2.06 xdiv Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+58 -00 replies
11/22target-ppc: Add VSX ISA2.06 xre Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+44 -00 replies
12/22target-ppc: Add VSX ISA2.06 xsqrt Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+53 -00 replies
13/22target-ppc: Add VSX ISA2.06 xrsqrte Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+54 -00 replies
14/22target-ppc: Add VSX ISA2.06 xtdiv Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+76 -00 replies
15/22target-ppc: Add VSX ISA2.06 xtsqrt Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+63 -00 replies
16/22target-ppc: Add VSX ISA2.06 Multiply Add Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+172 -00 replies
17/22target-ppc: Add VSX xscmp*dp Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+45 -00 replies
18/22target-ppc: Add VSX xmax/xmin Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+57 -00 replies
19/22target-ppc: Add VSX Vector Compare Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+87 -00 replies
20/22target-ppc: Add VSX Floating Point to Floating Point Conversion Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+57 -00 replies
21/22target-ppc: Add VSX ISA2.06 Integer Conversion Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+173 -00 replies
22/22target-ppc: Add VSX Rounding Instructionstarget-ppc/fpu_helper.c target-ppc/helper.h target-ppc/translate.c+113 -00 replies

Reviews trailers per patch

20 of 22 patches have a Reviewed-by or Acked-by.

PatchPeter Maydell
1/22R-b
2/22R-b
3/22
4/22
5/22R-b
6/22R-b
7/22R-b
8/22R-b
9/22R-b
10/22R-b
11/22R-b
12/22R-b
13/22R-b
14/22R-b
15/22R-b
16/22R-b
17/22R-b
18/22R-b
19/22R-b
20/22R-b
21/22R-b
22/22R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [Qemu-devel] [V5 PATCH 00/22] target-ppc: PowerPC VSX Stage 3

This is the third series of patches to add PowerPC VSX emulation support to QEMU.

This series adds the floating point arithmetic, compare, conversion and rounding instructions. Instructions are implemented using helpers and wherever practical, existing floating point code such as the softfloat library and the existing PowerPC floating point helper code.

As with the previous series, the Power ISA V2.06 instructions are added but the V2.07 instructions are not. The latter will be implemented in a future patch series.

V2: Implemented changes based on feedback from Richard Henderson and Peter Maydell:
- Included float64_to_uint64() patch in this series rather than just cite it as a pre-requesite.
- Isolated float32_to_uint64() in its own patch.
- Re-implemented helpers and eliminated the need for some of the proposed softfloat routines (float*_is_denormal, float*_get_unbiased_exp).
- Re-implemented severy helpers so that corner cases (e.g. invalid operations) are detected by softfloat.
- Re-implemented fused multiply-add to use the softfloat muladd routines.
- Re-implemented the min/max instructions to used the softfloat min/max functions.
- assorted style fixes

V3: re-submitting due to patch corruption.

V4: Folded in softfloat bug fixes per Peter Maydell's request.

V5: Additional comments from Peter Maydell and Richard Henderson:
- proper handling of NaNs with negative signs in conversion routines.
- proper rounding of small negatives in float32_to_uint64
- simplification of max/min instructions using new softfloat routines.
- assorted commentary changes.

Tom Musta (22):
softfloat: Fix float64_to_uint64
softfloat: Add float32_to_uint64()
softfloat: Fix float64_to_uint64_round_to_zero
softfloat: Fix float64_to_uint32
softfloat: Fix float64_to_uint32_round_to_zero
target-ppc: Add set_fprf Argument to fload_invalid_op_excp()
target-ppc: General Support for VSX Helpers
target-ppc: Add VSX ISA2.06 xadd/xsub Instructions
target-ppc: Add VSX ISA2.06 xmul Instructions
target-ppc: Add VSX ISA2.06 xdiv Instructions
target-ppc: Add VSX ISA2.06 xre Instructions
target-ppc: Add VSX ISA2.06 xsqrt Instructions
target-ppc: Add VSX ISA2.06 xrsqrte Instructions
target-ppc: Add VSX ISA2.06 xtdiv Instructions
target-ppc: Add VSX ISA2.06 xtsqrt Instructions
target-ppc: Add VSX ISA2.06 Multiply Add Instructions
target-ppc: Add VSX xscmp*dp Instructions
target-ppc: Add VSX xmax/xmin Instructions
target-ppc: Add VSX Vector Compare Instructions
target-ppc: Add VSX Floating Point to Floating Point Conversion
Instructions
target-ppc: Add VSX ISA2.06 Integer Conversion Instructions
target-ppc: Add VSX Rounding Instructions

 fpu/softfloat.c         |  191 ++++++++--
 include/fpu/softfloat.h |    1 +
 target-ppc/fpu_helper.c |  991 ++++++++++++++++++++++++++++++++++++++++++++---
 target-ppc/helper.h     |  109 ++++++
 target-ppc/translate.c  |  243 ++++++++++++
 5 files changed, 1455 insertions(+), 80 deletions(-)