Skip to content

delegation state fixes and cleanups for 3.13

Benny Halevy linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7nfsd4: fix recall_lock use in unhash_delegationfs/nfsd/nfs4state.c+1 -15 replies
2/7nfsd4: need to destroy revoked delegations in destroy_clientfs/nfsd/nfs4state.c+7 -03 replies
3/7nfsd4: properly hash delegation in nfs4_setleasefs/nfsd/nfs4state.c+12 -50 replies
4/7nfsd4: hash deleg stateid only on successful nfs4_set_delegationfs/nfsd/nfs4state.c+1 -12 replies
5/7nfsd4: cleanup hash and unhash delegationfs/nfsd/nfs4state.c+3 -20 replies
6/7nfsd4: move nfs4_put_file from unhash to put delegationfs/nfsd/nfs4state.c+2 -22 replies
7/7nfsd4: hold recall_lock while accessing nfs4_delegation.dl_recall_lrufs/nfsd/nfs4state.c+14 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] delegation state fixes and cleanups for 3.13

commit c7342d3cf5d5677063cbc6341634ed8cea1b176f

Author: Benny Halevy <[email protected]>
Date:   Tue Oct 15 17:07:31 2013 +0300

nfsd4: fix recall_lock use in unhash_delegation

Access to dp->dl_perclnt must be synchronized by the recall_lock

commit 87174785bcec37371b718757af67dde0f6d083e3

Author: Benny Halevy <[email protected]>
Date:   Tue Oct 15 17:29:13 2013 +0300

nfsd4: need to destroy revoked delegations in destroy_client

[use list_splice_init]

commit 775a7353f9d1e60ebd9096b1a82bfb78fe7f3cc9

Author: Benny Halevy <[email protected]>
Date:   Tue Oct 15 17:41:53 2013 +0300

nfsd4: properly hash delegation in nfs4_setlease

keep all accesses via dl_perclnt under the recall_lock.

commit fdf586869a6b026893f818cb538574a7b77f5604

Author: Benny Halevy <[email protected]>
Date:   Tue Oct 15 21:08:48 2013 +0300

nfsd4: hash deleg stateid only on successful nfs4_set_delegation

We don't want the stateid to be found in the hash table before the delegation is granted.

commit 635a93446fde8d8fb1f4bb825926750d9b6aea9d

Author: Benny Halevy <[email protected]>
Date:   Tue Oct 15 23:46:55 2013 +0300

nfsd4: cleanup hash and unhash delegation

make sure all atomic ops are under the recall_lock

commit 39f26e5974f73b62144abde6793d41b07a32719a

Author: Benny Halevy <[email protected]>
Date:   Tue Oct 15 23:50:30 2013 +0300

nfsd4: move nfs4_put_file from unhash to put delegation

revoked delegations are unhashed but are kept around in nfsv4.1 and we better
hang on to dp_file in this case.

commit cd2b2cac09cbd45419ce7d0e354dd94537a4fbfb

Author: Benny Halevy <[email protected]>
Date:   Wed Oct 16 00:17:14 2013 +0300

nfsd4: hold recall_lock while accessing nfs4_delegation.dl_recall_lru