Skip to content

udoo: Improve stability of DDR3 setting

Stefano Babic u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/4] udoo: Improve stability of DDR3 setting

Hi Giuseppe,

Quoted 4 lines · Giuseppe Pagano

Sorry, I used vim and imported patch as a file in evolution, I understood too late that I also need to change Format from "normal" to "preformatted". In the future I will use "git send-email".

Ok

Quoted 7 lines
Quoted 4 lines

Please take a look at the rules to submit patches :

http://www.denx.de/wiki/U-Boot/Patches

Sure, I read it, nevertheless I made lots of errors. This was my first submit..sorry

No problem ;-)

Quoted 8 lines
Quoted 5 lines

Do not fix multiple issues in the same patch if not strictly needed. The commit message is misleading: you say you are moving the configuration files, but they are not moved (they can't because they belong to nitrogen) and new files are generated.

Maybe I was wrong in writing "move configuration files.."

Quoted 8 lines

I think [PATCH 0/4] can be consider an atomical change: Fabio first uDoo support adopt nitrogenx register setting for DDR3, clock, muxing, etc

uDoo schematics is rather different from nitrogen6x, and it needs customized setting for most of the register (as every platform). It takes too long describe every single new setting. Previous configuration was very unstable and adopting those settings uDoo board has frequently crash.

Ok - this is an explanation that can be simply added to the commit message.

Quoted 6 lines
Quoted 2 lines

If you make change to a board, you should send your patches in CC to the board maintainer, too (for udoo, Fabio: I put him in CC).

Fabio was abreast of this changes, but not in cc. I'll use CC in next post.

Thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================