Skip to content

Socfpga: clk: trivial fixes and cleanup

Dinh Nguyen linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Socfpga: clk: trivial fixes and cleanup
Quoted 22 lines · Dinh Nguyen

Hi Steffen,

Quoted 9 lines · Steffen Trumtrar

Hi!

This series includes two trivial fixes to the code (1,2), then goes on to split the single clk.c file up into clock-type specific files (3) and finally adds a divider to the peripheral clock path.

The patches are rebased to the for-next branch of

Quoted 8 lines

git://git.rocketboards.org/linux-socfpga-next.git

Regards,
Steffen

Steffen Trumtrar (4):
ARM: socfpga: clk: remove unused field
ARM: socfpga: clk: fix define typo

The first two patches are fine.

Quoted 7 lines
Quoted 2 lines

ARM: socfpga: clk: split clk code
ARM: socfpga: clk: add clk_divider to periph

These two patches are causing the ethernet driver to not be able to grab the correct clock during probe.

Lets wait for 3.13-rc1 and I will push a new for-next that will be more up-to-date.

Also the values do not look correct with your patch:

per_nand_mmc_clk 1 1 52631578

          nand_clk              0           0            13157894
          nand_x_clk            0           0            52631578
          sdmmc_clk             1           1            52631578

Without your patch:

per_nand_mmc_clk 1 1 50000000

          nand_clk              0           0            12500000
          nand_x_clk            0           0            50000000
          sdmmc_clk             1           1            50000000

Dinh

Quoted 23 lines

Thanks,

Dinh

Quoted 12 lines
 drivers/clk/socfpga/Makefile     |   3 +
 drivers/clk/socfpga/clk-gate.c   | 197 ++++++++++++++++++++++++
 drivers/clk/socfpga/clk-periph.c |  87 +++++++++++
 drivers/clk/socfpga/clk-pll.c    | 114 ++++++++++++++
 drivers/clk/socfpga/clk.c        | 313 +--------------------------------------
 drivers/clk/socfpga/clk.h        |  56 +++++++
 6 files changed, 458 insertions(+), 312 deletions(-)
 create mode 100644 drivers/clk/socfpga/clk-gate.c
 create mode 100644 drivers/clk/socfpga/clk-periph.c
 create mode 100644 drivers/clk/socfpga/clk-pll.c
 create mode 100644 drivers/clk/socfpga/clk.h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel