Skip to content

RFC DT support for ST micro accelerometers and gyroscopes

Jonathan Cameron linux-arm-kernel linux-devicetree linux-iio 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 of 3 patches 0 repliesNew

1 of 3 patches is in this archive. The cover letter announces 3.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3iio: accel: Add device tree probing for STMicro accelerometers+0 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/3] DT support for ST micro accelerometers and gyroscopes

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 15 lines · Maxime Ripard

Hi Jonathan,

Quoted 12 lines · Jonathan Cameron

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Quoted 8 lines · Maxime Ripard

Hi Denis,

Quoted 1 line · Denis CIOCCA

only one point: it's possible to use the same names with DT? (using _ instead of -)

Yes, it is, but only for i2c as far as I'm aware, and usually the DT compatibles are with - as a separator (I looked into the ePAPR, but couldn't get any explanations or requirements on this, even though it's used in all of their examples)

Quoted 5 lines
Quoted 3 lines

In other discussions, where the defacto i2c device tree bindings have been followed, the conclusion has been that to change to a - from _ would result in userspace ABI changes, so whilst no one wants _ the discussion has concluded we can't really avoid it.

What kind of userspace ABI changes are we talking about?

IIRC:

i2c has a generic binding that matches to the name bit of the i2c_device_id array. That is then exported in sysfs. There are quite a lot of instances of underscores out there in these names. Thus unforutnately they can't be changed without possibly breaking userspace. Typically those same names are also output by IIO though obviously we could keep that the same whilst changing the dt binding.

Also the i2c binding allows binding after dropping the vendor prefix which is even more 'interesting'. See of_modialias_node in drivers/of/base.c

I'd therefore argue in favour of just leaving the underscores in existing drivers as a nasty bit of legacy and doing our best to not introduce any new ones!

Jonathan

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSmdOzAAoJEFSFNJnE9BaIilUP/RPwSswdYi9wWtN0tBEFfZvo JO0bybjw342LE2xt3DXd7fo04v1+LspWxatw6kht1mJ/aU6O4HwNHQpPO7Md5pDm 4HPoPSREaDbYEOqhVSjXaBUOXIOYSe392KtqKJMRSxRs3XiIeqYPfojqtIE2KF7a W3EEjud5wrWuOLKtdQWjRt+UpDnewImR+qORtRUoA7NY2YIHvdarOQFlfDqLXSRK GvE49O8jCtQvcjI1rsybMRXQkUF3GE8hLyATaf/SbvgVeILbHSl6OvaN7O7nNJ+b DGGrzAzmKwj56G47imQ7z2v/D9ExWNwr1DZ2CMPt+yXQ15OBXDnAmWGXTr45/dUl G8PjaZA9GKsp0dE713b0RN/eJnsoFsJd8bDCeXh9IpVblmkQzW3HsvI8p2Uj8xga 5d/txeXytLNvHj+3OiiVTaKA3Y9/dFNq9dwI+QAMbLY87T4ft70z533liTZRnMWG 2O8x2oHYnoFRH3qmpg6jy3/qCFe6wTTXy1yMFQ0Ds/bJ93vhrv7SiXXsxX3CNl9X KI8t74zx51GMxBV5pMixgX9aBH7Wrn+WSXmUKkMkm7JGbeicZEjk259EjAluuohD HHh0cehjCuVPY6PTUhkXTfCFDfpFtwOkXsZb6fOMS2wDKK4BLwb3SPwyn+ID7XJs u/RQzwNNjvdsR2hmBQOw
=lpwt
-----END PGP SIGNATURE-----