Impedance matcher for Samsung boards
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 8 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 8 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/8] Impedance matcher for Samsung boards
Quoted 38 lines · Tomasz Figa
Quoted 37 lines · On Wednesday 11 of December 2013 15:10:39 Daniel Mack wrote:
Quoted 24 lines · Piotr Wilczek
Hi,
Quoted 22 lines
-----Original Message----- From: Daniel Mack [mailto:zonque at gmail.com] Sent: Wednesday, December 11, 2013 2:17 PM To: Piotr Wilczek; devicetree-discuss at lists.ozlabs.org; linux-arm- kernel at lists.infradead.org Cc: Jason Cooper; Nicolas Pitre Subject: Re: [PATCH 0/8] Impedance matcher for Samsung boards
Quoted 8 lines · Piotr Wilczek
This patchset implements the impedance-matcher for Samsung Exynos boards and does the following: - fix strncmp function; - ensure each DT blob is 4-byte aligned; - port '
atags_to_fdt' form Kernel; - add Exynos specific serial driver; - add support for Samsung boards, Trats and Trats2;This patch set is based on:
https://github.com/zonque/pxa-impedance-matcher.gitThanks for the patches!
I'm considering merging most of them, but I have my problems with the inclusion of the libfdt library.
Quoted 6 lines
Quoted 3 lines
Could you explain what you need this for, exactly? Why can't you just fix the device tree blob that you include instead of modifying it at runtime?
When bootloader needs to pass some information in ATAGS and
CONFIG_ARM_APPENDED_DTBis turned off in kernel, then it has to be added to the device tree blob at runtime.The question is: can't you just provide a dtb for each of your machines, and distinguish them via their machine ID? Or do you really have machines that come up with the same machine ID but differ in details only stored in ATAGs?
Quoted 6 lines
Quoted 1 line
After all, adding libfdt makes the code grow by more than factor 4.
There are some parameters that bootloaders normally pass with ATAGS and can't be hardcoded in DT, such as initrd location in memory, serial number, board revision, command line and in some cases even memory, as on some boards it might vary between units.
Ok, that was my question :) Sure, if you have units that differ in hardware details, but are indistinguishable by their machine ID or board revision number, there's not much that we can do but modify the FDT at runtime. Serial numbers are also something that can't be solved in a nicer way.
What bugs me, though, is that it blows up the code base so massively.
So I'm about to merge this. Jason, and final thoughts?
Thanks,
Daniel