Skip to content

ipmi: fix timeout calculation when bmc is disconnected

Xie XiuQi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ipmi: use USEC_PER_SEC instead of 1000000 for more meaningfuldrivers/char/ipmi/ipmi_bt_sm.c drivers/char/ipmi/ipmi_kcs_sm.c drivers/char/ipmi/ipmi_smic_sm.c+7 -70 replies
2/2ipmi: fix timeout calculation when bmc is disconnecteddrivers/char/ipmi/ipmi_si_intf.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ipmi: fix timeout calculation when bmc is disconnected

Hu Shiyuan report, when loading ipmi_si module while bmc is disconnected, we found the timeout is longer than 5 secs. Actually it takes about 3 mins and 20 secs (HZ=250).

error message as below:

Dec 12 19:08:59 linux kernel: IPMI BT: timeout in RD_WAIT [ ] 1 retries left
Dec 12 19:08:59 linux kernel: BT: write 4 bytes seq=0x01 03 18 00 01
[...]
Dec 12 19:12:19 linux kernel: IPMI BT: timeout in RD_WAIT [ ]
Dec 12 19:12:19 linux kernel: failed 2 retries, sending error response
Dec 12 19:12:19 linux kernel: IPMI: BT reset (takes 5 secs)
Dec 12 19:12:19 linux kernel: IPMI BT: flag reset [ ]

Function wait_for_msg_done() use schedule_timeout_uninterruptible(1) to sleep 1 tick, so we should subtract jiffies_to_usecs(1) usecs instead of 100 usecs from timeout.

For more clearly, I used USEC_PER_SEC instead of 1000000.

Xie XiuQi (2):
ipmi: use USEC_PER_SEC instead of 1000000 for more meaningful
ipmi: fix timeout calculation when bmc is disconnected

 drivers/char/ipmi/ipmi_bt_sm.c   | 8 ++++----
 drivers/char/ipmi/ipmi_kcs_sm.c  | 4 ++--
 drivers/char/ipmi/ipmi_si_intf.c | 2 +-
 drivers/char/ipmi/ipmi_smic_sm.c | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
1.8.2.2