bonding: add port protection for bond_3ad_xxx_change()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | bonding: protect port for bond_3ad_adapter_speed_changed()drivers/ | +8 | 0 replies | |
| 2/3 | bonding: protect port for bond_3ad_adapter_duplex_changed()drivers/ | +8 | 0 replies | |
| 3/3 | bonding: protect port for bond_3ad_handle_link_change()drivers/ | +17 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net 0/3] bonding: add port protection for bond_3ad_xxx_change()
Jay Vosburgh said that the bond_3ad_adapter_speed_changed and bond_3ad_adapter_duplex_changed is called with RTNL only, and the functions will modify the port's information with no further locking, they will not mutex against bond state machine and incoming LACPDU which do not hold RTNL, So I add port lock to protect the port information.
But they are not critical bugs, they exist since day one, and till now they have never been hit and reported, because change for speed and duplex is very rare, and will not occur critical problem.
The comments in the function is very old, cleanup the comments together.
Ding Tianhong (3):
bonding: protect port for bond_3ad_adapter_speed_changed()
bonding: protect port for bond_3ad_adapter_duplex_changed()
bonding: protect port for bond_3ad_handle_link_change()
drivers/net/bonding/bond_3ad.c | 45 +++++++++++++++++++++++++++++++----------- 1 file changed, 33 insertions(+), 12 deletions(-)
Signature · 1 line
1.8.0