Skip to content

Sebastian Schuberth git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest4 patches 11 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Consistently use the term "builtin" instead of "internal command"Documentation/technical/api-builtin.txt git.c+8 -83 replies
2/4Call load_command_list() only when it is neededbuiltin/help.c+2 -10 replies
3/4Speed up is_git_command() by checking early for internal commandsDocumentation/technical/api-builtin.txt builtin.h builtin/help.c +1 more+134 -1176 replies
4/4Move builtin-related implementations to a new builtin.c fileDocumentation/technical/api-builtin.txt Makefile builtin.c +2 more+248 -2392 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4]

This is the second iteration of the patches in

http://www.spinics.net/lists/git/msg222428.html
http://www.spinics.net/lists/git/msg222429.html

which

* adds a commit to use the term "builtin" instead of "internal command",
* also modifies the docs accordingly,
* moves the is_builtin() declaration to the existing builtin.h,
* finally moves all builtin-related definitions to a new builtin.c file.

Sebastian Schuberth (4):
Consistently use the term "builtin" instead of "internal command" Call load_command_list() only when it is needed
Speed up is_git_command() by checking early for internal commands Move builtin-related implementations to a new builtin.c file

 Documentation/technical/api-builtin.txt |   4 +-
 Makefile                                |   1 +
 builtin.c                               | 225 ++++++++++++++++++++++++++++++
 builtin.h                               |  23 +++
 builtin/help.c                          |   6 +-
 git.c                                   | 238 +-------------------------------
 6 files changed, 262 insertions(+), 235 deletions(-)
 create mode 100644 builtin.c
Signature · 1 line
1.8.3-mingw-1