bonding: ensure that the TSO being set on bond master
Status from this message: Nacked-by: Veaceslav Falico <[email protected]>
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 4 repliesNAK
- v12 patches 4 repliesSuperseded
Patches in v2
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | bonding: move the netdev_add_tso_features() to bonding moduledrivers/ include/ | +11 | 0 replies | |
| 2/2 | bonding: try to enable SG features when adding a new, slavedrivers/ | +15 | 2 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Veaceslav Falico |
|---|---|
| Series | Nacked-by |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v2 0/2] bonding: ensure that the TSO being set on bond master
The commit b0ce3508(bonding: allow TSO being set on bonding master) has make the TSO being set for bond dev, but in some situation, if the slave did not have the NETIF_F_SG features, the bond master will miss the TSO features in netdev_fix_features because the TSO is depended on SG. So I have to add SG and TSO features on bond master together.
The function netdev_add_tso_features() was only be used for bonding, so no need to export it in netdevice.h, remove it and add it to bonding.
v2: If the slave hw did not support SG features, the SG should not
be forced open on master, otherwise error will occur, so modify it. Some slave may support SG but not open it yet, so the bond master could try to open it when adding the salve and make sure the TSO could be open on master.
Ding Tianhong (2):
bonding: move the netdev_add_tso_features() to bonding
bonding: try to enable SG features when adding a new slave
drivers/net/bonding/bond_main.c | 27 ++++++++++++++++++++++++++- include/linux/netdevice.h | 10 ---------- 2 files changed, 26 insertions(+), 11 deletions(-)
Signature · 1 line
1.8.0