Skip to content

NFSD/SUNRPC: Fix memory leak for the backchannel

Kinglong Mee linux-nfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/25 patches 1 replyIn review
  2. v1 posting 1/25 patches 5 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5NFSD: Using free_conn free connectionfs/nfsd/nfs4state.c+2 -10 replies
2/5NFSD: Free backchannel xprt in bc_destroynet/sunrpc/xprtsock.c+4 -00 replies
3/5SUNRPC: New helper for creating client with rpc_xprtinclude/linux/sunrpc/clnt.h net/sunrpc/clnt.c+35 -250 replies
4/5NFSD/SUNRPC: Check rpc_xprt out of xs_setup_bc_tcpfs/nfsd/nfs4callback.c include/linux/sunrpc/xprt.h net/sunrpc/xprt.c +1 more+30 -230 replies
5/5SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failednet/sunrpc/xprtsock.c+2 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5][RESEND]NFSD/SUNRPC: Fix memory leak for the backchannel

When using pynfs test-site, I found some memory leak for the backchannel.

Kinglong Mee (5):
NFSD: Using free_conn free connection
NFSD: Free backchannel xprt in bc_destroy
SUNRPC: New helper for creating client with rpc_xprt NFSD/SUNRPC: Check rpc_xprt out of xs_setup_bc_tcp
SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed

 fs/nfsd/nfs4callback.c      | 19 ++++++++++++++-
 fs/nfsd/nfs4state.c         |  3 ++-
 include/linux/sunrpc/clnt.h |  2 ++
 include/linux/sunrpc/xprt.h | 13 +++++++++-
 net/sunrpc/clnt.c           | 58 ++++++++++++++++++++++++++-------------------
 net/sunrpc/xprt.c           | 12 ----------
 net/sunrpc/xprtsock.c       | 15 +++++-------
 7 files changed, 73 insertions(+), 49 deletions(-)
Signature · 1 line
1.8.5.3