RFC some download-related changes
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest6 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | Makefile: rename USER_HOOKS_EXTRA_ENV to EXTRA_ENV | +0 | 0 replies | |
| 2/6 | pkg-infra: move git download helper to a script | +0 | 1 reply | |
| 3/6 | pkg-infra: git helper creates an empty archive if PKG_VERSION is a missing hash | +0 | 1 reply | |
| 3/6 | pkg-infra: git helper creates an empty archive if PKG_VERSION is a missing hash | +0 | 1 reply | |
| 4/6 | package infra: DOWNLOAD is never called with two arguments | +0 | 0 replies | |
| 5/6 | pkg-infra: add possiblity to check downloaded files against known hashes | +0 | 1 reply | |
| 5/6 | pkg-infra: add possiblity to check downloaded files against known hashes | +0 | 5 replies |
Reviews trailers per patch
2 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Arnout Vandecappelle (Essensium/Mind) |
|---|---|
| 1/6 | R-b |
| 2/6 | |
| 3/6 | |
| 3/6 | |
| 4/6 | A-b |
| 5/6 | |
| 5/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH 0/6] [RFC] some download-related changes
Quoted 7 lines · Yann E. MORIN
The first part, patch 1 to 3, are a fix the git download helper, which is currently broken in case a
PKG_VERSIONis a sha1 that does not exist in the repository.Since the make macro was a bit complex to read and maintain, Peter suggested it be moved to a shell script. If this change is OK, I'll move the other download helpers to their own shell script.
I would actually move all of $(DOWNLOAD) into a single helper script. I
expect that that will give you a lot of refactoring opportunities.
But clearly that can wait for follow-up patches.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F