Skip to content

bonding: Fix some issues for fail_over_mac

Ding Tianhong netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5bonding: The fail_over_mac should be set only in ACTIVE_BACKUP modedrivers/net/bonding/bond_main.c+5 -32 replies
2/5bonding: don't set fail_over_mac if the mode is not active backupdrivers/net/bonding/bond_options.c+6 -00 replies
3/5bonding: set fail_over_mac to none if new mode is not active-backupdrivers/net/bonding/bond_options.c+6 -00 replies
4/5bonding: set fail_over_mac to active only in active-backup mode at enslavementdrivers/net/bonding/bond_main.c+2 -10 replies
5/5bonding: remove the redundant judgements for bond_set_mac_address()drivers/net/bonding/bond_main.c+0 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/5] bonding: Fix some issues for fail_over_mac

The parameter fail_over_mac only affect active-backup mode, if it was set to active or follow and works with other modes, just like RR or XOR mode, the bonding could not set all slaves to the master's address, it will cause the slave could not work well with master.

So set the fail_over_mac to none if the mode is not active-backup and slight optimization for bond_set_mac_address().

Ding Tianhong (5):
bonding: The fail_over_mac should be set only in ACTIVE_BACKUP mode
bonding: don't set fail_over_mac if the mode is not active backup
bonding: bonding: set fail_over_mac to none if new mode is not active-backup
bonding: set fail_over_mac to active only in active-backup mode at
enslavement
bonding: remove the redundant judgements for bond_set_mac_address()

 drivers/net/bonding/bond_main.c    | 19 +++++++------------
 drivers/net/bonding/bond_options.c | 12 ++++++++++++
 2 files changed, 19 insertions(+), 12 deletions(-)
Signature · 1 line
1.8.0