bonding: Fix some issues for fail_over_mac
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest posting 2/22 patches 3 repliesIn review
- v3 posting 1/22 patches 2 repliesSuperseded
- v13 patches 6 repliesSuperseded
Patches in v3 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | bonding: fail_over_mac should only affect AB mode at enslave and removal processingdrivers/ | +15 | 0 replies | |
| 2/2 | bonding: fail_over_mac should only affect AB mode in bond_set_mac_address()drivers/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH RESEND net-next v3 0/2] bonding: Fix some issues for fail_over_mac
The parameter fail_over_mac only affect active-backup mode, if it was set to active or follow and works with other modes, just like RR or XOR mode, the bonding could not set all slaves to the master's address, it will cause the slave could not work well with master.
v1->v2: According Jay's suggestion, that we should permit setting an option
at any time, but only have it take effect in active-backup mode, so I add mode checking together with fail_over_mac during enslavement and rebuild the patches.
v2->v3: The correct way to fix the problem is that we should not add restrictions when
setting options, just need to modify the bond enslave and removal processing to check the mode in addition to fail_over_mac when setting a slave's MAC during enslavement. The change active slave processing already only calls the fail_over_mac function when in active-backup mode.
Remove the cleanup patch because the net-next is frozen now.
Regards
Ding
Ding Tianhong (2):
bonding: bonding: fail_over_mac should only affect AB mode at
enslave and removal processing
bonding: fail_over_mac should only affect AB mode in
bond_set_mac_address()
drivers/net/bonding/bond_main.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-)
Signature · 1 line
1.8.0