Skip to content

Introducing the Broadcom bcm281xx Architecture

Darwin Rambo u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 6 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/6] Introducing the Broadcom bcm281xx Architecture
Quoted 16 lines · Tom Rini
Quoted 6 lines · Darwin Rambo

This patchset introduces the Broadcom bcm281xx family of mobile SoC chips. Broadcom kona hardware blocks are often found in Broadcom mobile SoC chips including the bcm281xx family, so support for some of these kona blocks is also provided here. These patches work on u-boot master as well as the u-boot-arm custodian tree.

Quoted 7 lines

Darwin Rambo (6):
arch: kona: Initial commit of kona-common architecture code
arch: bcm281xx: Initial commit of bcm281xx architecture code
gpio: kona: Add Kona gpio driver
i2c: kona: Add Kona I2C driver
mmc: kona: Add Kona mmc driver
board: bcm28155_ap: Add board files

Quoted 8 lines

Thanks for posting. Globally, please don't introduce another style for the file header,
/*
* This works
* just fine.
*
* Including what the file is about
*/

OK - legacy stuff will be fixed.

Quoted 7 lines

And I also see the incorrect style sprinkled throughout.

I saw some '#define<tab>' mixed in with '#define<space>', and some other things I'd have sworn checkpatch complains about, so please make sure things are checkpatch clean (except for very long printed strings, which are an exception to line length rules).

Well, checkpatch was clean, so I think there's a problem with the tool. Another minor gripe is that checkpatch and "indent -linux" don't agree on everything, "int * foo" being one of them. :)

Quoted 3 lines

Finally, please CC the custodians for i2c/mmc for those drivers as they may have further comments than the above list.

OK. There are mmc, i2c and gpio drivers. I assume each driver gets a different CC:?

Quoted 3 lines

Thanks!

Thanks to you too!

Read the cover letter in its thread