Skip to content

mv64xxx updates

Gregory CLEMENT linux-arm-kernel linux-i2c 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 of 5 patches 0 repliesNew

3 of 5 patches are in this archive. The cover letter announces 5.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5i2c: mv64xxx: put offload check into offload prepare function+0 -00 replies
2/5i2c: mv64xxx: refactor message start to ensure proper initialization+0 -01 reply
3/5i2c: mv64xxx: refactor send_start+0 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchGregory CLEMENT
1/5T-b
2/5T-b
3/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] mv64xxx updates

Hi Wolfram,

Quoted 9 lines · Wolfram Sang

So, this is a series I came up with trying to fix the issue found by Kevin. Patches 1+2 are hopefully fixing the bug (in theory, I don't have the HW). Patches 3-5 are RFC, and if patch 3 actually works (see the CHECKME), then 4+5 are further cleanup possibilities. And there is still more potential, I mainly wanted to give some inspiration and awareness that the driver could need some more love. Please test at least 1+2, comments to 3-5 very welcome.

Sorry for the delay, I got distracted by an NMI.

Thanks for this series, indeed the code looks better.

I will test it tomorrow and let you know if it fixed the bug. I will also take time to review the RFC patches.

Greogry

Quoted 10 lines

Wolfram Sang (5):
i2c: mv64xxx: put offload check into offload prepare function
i2c: mv64xxx: refactor message start to ensure proper initialization
i2c: mv64xxx: refactor send_start
i2c: mv64xxx: directly call send_start when initializing transfer
i2c: mv64xxx: refactor initialization for new msgs

 drivers/i2c/busses/i2c-mv64xxx.c | 67 ++++++++++++++++------------------------
 1 file changed, 27 insertions(+), 40 deletions(-)
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com