Skip to content

Fix RTNL: assertion failed at net/core/rtnetlink.c

Ding Tianhong netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 4 repliesSuperseded
  3. v11 patch 9 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for 802.3ad modedrivers/net/bonding/bond_3ad.c drivers/net/bonding/bond_main.c drivers/net/bonding/bonding.h+75 -220 replies
2/2bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for ab arp monitordrivers/net/bonding/bond_3ad.c drivers/net/bonding/bond_main.c drivers/net/bonding/bonding.h+55 -460 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchThomas Glanzmann
SeriesT-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net v3 0/2] Fix RTNL: assertion failed at net/core/rtnetlink.c

The commit 1d3ee88ae0d
(bonding: add netlink attributes to slave link dev) make the bond_set_active_slave() and bond_set_backup_slave() use rtmsg_ifinfo to send slave's states and this functions should be called in RTNL.

But the 902.3ad and ARP monitor did not hold the RTNL when calling thses two functions, so fix them.

v1->v2: Add new micro to indicate that the notification should be send
later, not never.
And add a new patch to fix the same problem for ARP mode.

v2->v3: modify the bond_should_notify to should_notify_rtnl, it is more
reasonable, and use bool for should_notify_rtnl.

Ding Tianhong (2):
bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for

    802.3ad mode

bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for ab
arp monitor

 drivers/net/bonding/bond_3ad.c  |  16 +++++-
 drivers/net/bonding/bond_main.c | 115 ++++++++++++++++++++++------------------
 drivers/net/bonding/bonding.h   |  47 ++++++++++++++--
 3 files changed, 120 insertions(+), 58 deletions(-)
Signature · 1 line
1.8.0