Skip to content

ARM: OMAP4: Fix gpmc_fck clock

Suman Anna linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest0 of 2 patches 0 repliesNew

Patches in v2 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] ARM: OMAP4: Fix gpmc_fck clock

Florian,

Quoted 41 lines · Florian Vaussard
Quoted 30 lines · Mike Turquette

Quoting Florian Vaussard (2014-02-23 21:44:25)

Quoted 29 lines · Mike Turquette
Quoted 27 lines

Quoting Florian Vaussard (2014-02-19 11:26:43)

Quoted 14 lines · Tero Kristo
Quoted 12 lines · Florian Vaussard
Quoted 11 lines

Hello,

Trying to get my SMSC9221 working on OMAP4 with DT, I faced a misconfigured gpmc_fck (dummy clock set to 0) resulting in serveral division-by-zero, misconfigured timings and driver lost in the La La Land.

To solve this, patch 1 removes gpmc_fck from the dummy clocks, and patch 2 adds the gpmc_fck DT node and reference it from the gpmc node.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Tested on DuoVero/Parlor (OMAP4430) with SMSC9221.

I can't test GPMC myself, but other than that, this set looks good to go.

Thank you. Would you like more test coverage by other people? I would like to see this in -rc if possible, as it is needed to boot my OMAP4 system.

What OMAP4 system is this? Is this a regression for board that already has support merged into mainline?

Quoted 9 lines
Quoted 4 lines

No, it is not yet merged into mainline. I was planning to post the DTS this week, when most issues are cleared. Looking at the current mainline boards, no one seems to use the GPMC, so I am just the first one to hit this issue.

OK, well typically the later -rc's are for fixing observed regressions. Since your platform is not yet merged in then it's probably fine to push this for 3.15.

Quoted 7 lines

Fair enough. 3.15 is fine.

Quoted 2 lines

This also gives time to test the fix for other OMAP-ish processors.

I can do the v3, including OMAP5 and DRA7. But for DRA7, I will need someone with the TRM telling me where is connected gpmc_fclk (Suman?).

For DRA7, GPMC is connected off L3MAIN1_L3_GICLK (compared to L3MAIN2_L3_GICLK on OMAP5), both of which are actually just L3_ICLK. This is the l3_iclk_div in both the omap54xx-clocks.dtsi and dra7xx-clocks.dtsi files.

regards
Suman