Skip to content

ath9k|ath9k_htc: move dups to common-beacon

Oleksij Rempel ath9k-devel linux-wireless 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 23 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 23 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [ath9k-devel] [PATCH 00/23] ath9k|ath9k_htc: move dups to common-beacon

Am 06.03.2014 19:42, schrieb John W. Linville:

Quoted 9 lines · Sujith Manoharan
Quoted 8 lines
Quoted 4 lines · Oleksij Rempel

I was thinking about it too, but suddenly i don't have enough time and experience to do it. Beside, there is no need to write usb layer. It is clean and separate from other part of the driver. But the HTC/WMI interface is not completely separate.

Sure. It is just another option to consider.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Now about bigger picture. Right now i work only on ath9k<>ath9k_htc dups. But there are lots of dup code in ath9k itself. For example *_phy.c, *_initvals.h. Here are some examples:

We already have duplicate detection for initvals. It is part of the initvals tool in qca-swiss-army-knife.

So, where does this leave us? Should this series be merged? Or not?

Last response was about initvals, my patch set affect only beacon code. Since i don't plan to rewrite ath9k_htc from scratch, i would assume it will be better to continue this periodic clean work.

Sujith, are you agree? :) We need your Ack for this patch set.

Signature · 10 lines
Regards,
Oleksij

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 278 bytes
Desc: OpenPGP digital signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20140307/5cd7dc56/attachment.pgp