Skip to content

Documentation cleanup

Jerzy Grzegorek buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 9 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/9] Documentation cleanup

Hi Thomas,

Quoted 14 lines

Dear Jerzy Grzegorek,

Quoted 2 lines · Jerzy Grzegorek

Here is a series that fixes a few typoes and makes small improvements in documentation.

I've applied patches 1 to 6, 8 and 9. For patch 2, I made the change we discussed.

I haven't applied patch 7, because I don't agree with:

(quoted diff) +2 -0
+series is introduced by a cover letter, an overall patch version may be
+added to the cover letter in addition/instead to the individual commits.
Quoted 5 lines

The version in the title of the cover letter does *not* replace the version in the title of the patches. Both should be present, so the "/instead" is not correct. Also, the "may be added" does not seem right, because a version is always added to the cover letter title by "git format-patch --subject-prefix".

Regarding the "may be added", I agree.
I proposed this change because I saw on mailing list both cases of submitting patch series introduced by a cover letter:

* "in addition" case:

     [Patch vX 0/Y] ...
     [Patch vX 1/Y] ...
     ...
     [Patch vX Y/Y] ...

* "instead" case:

     [Patch vX 0/Y] ...
     [Patch 1/Y] ...
     ...
     [Patch Y/Y] ...

but ok, agree.
So maybe it should be:
"Note that when your patch series is introduced by a cover letter, a patch version should be added to the cover letter in addition to the individual commits."

Regards,
Jerzy

Quoted 4 lines

Best regards,

Thomas