Skip to content

ARM: exynos: cpuidle: Move the driver to drivers/cpuidle

Daniel Lezcano linux-arm-kernel linux-samsung-soc 8 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 4/40 of 20 patches 0 repliesNew
  2. v5 posting 3/40 of 20 patches 0 repliesSuperseded
  3. v5 posting 2/40 of 20 patches 0 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v5 posting 1/420 patches0 repliesSuperseded
v420 patches0 repliesSuperseded
v317 patches0 repliesSuperseded
v217 patches0 repliesSuperseded
v10 of 17 patches0 repliesSuperseded

Patches in v5 posting 4/4 No applies recorded yet

None of the 20 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchArnd BergmannHeiko StuebnerTomasz Figa
SeriesA-b A-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH V5 00/20] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle
Quoted 22 lines · Kukjin Kim
Quoted 21 lines · Kukjin Kim
Quoted 8 lines · Tomasz Figa
Quoted 5 lines · Daniel Lezcano

Hi Kukjin,

I believe I addressed all the comments. Is it possible to take this patchset for next ?

Sure ;-)

Quoted 8 lines

+1.

Also when applying you might add

Reviewed-by Tomasz Figa<[email protected]>

to any patches that don't have it yet.

Tomasz, thanks for your review.

Quoted 7 lines
Quoted 3 lines

I will take this series, "moving exynos-cpuidle into drivers/cpuidle" into samsung tree if Rafael is OK on that.

Daniel,

Can you please check/test the functionality your series with using my for-next because there were merge conflicts with mcpm-exynos stuff...?

Hi Kukjin,

I tested the latest tree. Unfortunately it panics when unplugging cpu1:

[    3.124189] Unable to handle kernel paging request at virtual address f8400024
[    3.129950] pgd = c0004000
[    3.132626] [f8400024] *pgd=6f7f7841, *pte=00000000, *ppte=00000000
[    3.138877] Internal error: Oops: 827 [#1] PREEMPT SMP ARM
[    3.192782] r3 : f8400024  r2 : f8180800  r1 : ee836e44  r0 : f8400024
[    3.199293] Flags: nZCv  IRQs off  FIQs on  Mode SVC_32  ISA ARM Segment kernel
[    3.206673] Control: 10c5387d  Table: 6e37c04a  DAC: 00000015
[    3.212398] Process swapper/0 (pid: 0, stack limit = 0xc0510240)
[    3.218388] Stack: (0xc0511ef4 to 0xc0512000)
[    3.222728] 1ee0: 00000030 c02b20f8 ee836e40
[    3.230894] 1f00: c001234c 6e880000 c0511f34 40018a80 00000000 00000000 00000000 00000015
[    3.239053] 1f20: 4000404a 10c5387d 00000041 00f00000 00000000 00000000 c02b20e4 edc4a540
[    3.247212] 1f40: c038dacc eefc5cf8 c050ecf0 c0543210 00000000 c0012460 00000001 c0543210
[    3.255371] 1f60: eefc5cf8 c02b2148 b9f92927 00000000 c054326c c02b0968 b9f92927 00000000
[    3.263530] 1f80: c0510000 c0518480 c038dacc c0510000 c0510000 c0518480 c038dacc eefc5cf8
[    3.271689] 1fa0: c0543210 c004e990 c0511fb4 c03873b8 00000000 c04f90c8 00000000 c04d4b18
[    3.279848] 1fc0: ffffffff ffffffff c04d457c 00000000 00000000 c04f90c8 00000000 10c5387d
[    3.288007] 1fe0: c0518410 c04f90c4 c051bd5c 4000406a 00000000 40008074 00000000 00000000
[    3.296184] [<c0019c5c>] (exynos_enter_aftr) from [<c02b20f8>] (idle_finisher+0x14/0x20)
[    3.304247] [<c02b20f8>] (idle_finisher) from [<c001234c>] (cpu_suspend_abort+0x0/0x14)
[    3.312226] [<c001234c>] (cpu_suspend_abort) from [<00000000>] (  (null))
[    3.318994] Code: e34f3840 e3500010 11a00002 01a00003 (e5804000)
[    3.325069] ---[ end trace fca911f75a18c040 ]---

After git bisecting I falls on this commit:

commit b3205dea8fbf6db9b1e46a0dad19a0712fdff44f

Author: Sachin Kamat <[email protected]>
Date:   Tue May 13 07:13:44 2014 +0900

ARM: EXYNOS: Map SYSRAM through generic DT bindings

Instead of hardcoding the SYSRAM details for each SoC, pass this information through device tree (DT) and make the code SoC agnostic. Generic DT SRAM bindings are used for achieving this.

Signed-off-by Sachin Kamat <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Acked-by Heiko Stuebner <[email protected]>
Reviewed-by Tomasz Figa <[email protected]>
Signed-off-by Kukjin Kim <[email protected]>

... which is before my series is applied.

So I am not able to tell yet if my series is correctly rebased or not.

And before someone asks me, yes I updated the dtb :)

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Read the cover letter in its thread