SRP initiator patches for kernel 3.16
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest9 patches 2 repliesIn review
- v39 patches 2 repliesSuperseded
- v29 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 9 patches | 21 replies | Superseded |
Changes in v4 from the cover letter
- Fixed test robot complaints ("undefined reference to `__udivdi3'" and "warning: format '%d' expects a matching 'int' argument").
- Restored support for HCA's that neither support FMR nor FR.
- Simplified memory registration pool reallocation code in srp_create_target_ib(). If FMR or FR is supported, an memory registration pool is allocated. If this fails, an error code is returned. If neither FMR nor FR is supported no attempt is made to allocate a memory registration pool.
- Minimized the changes in srp_add_one(). The decision to limit sg_tablesize is now based on whether or not the HCA supports memory registration instead of whether allocation of a memory registration pool succeeded. This change allows to keep the resource allocation order unmodified.
- Fixed a (theoretical ?) memory registration failure that was introduced in Linux kernel v2.6.39 (state->npages being compared against SRP_FMR_SIZE instead of max_pages_per_fmr).
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | IB/srp: Fix a sporadic crash triggered by cable pullingdrivers/ | +6 | 0 replies | |
| 2/9 | IB/srp: Fix kernel-doc warningsdrivers/ | +7 | 0 replies | |
| 3/9 | IB/srp: Introduce an additional local variabledrivers/ | +4 | 0 replies | |
| 4/9 | IB/srp: Introduce srp_map_fmr()drivers/ | +45 | 0 replies | |
| 5/9 | IB/srp: Introduce srp_finish_mapping()drivers/ | +27 | 0 replies | |
| 6/9 | IB/srp: Introduce the 'register_always' kernel module parameterdrivers/ | +7 | 0 replies | |
| 7/9 | IB/srp: One FMR pool per SRP connectiondrivers/ drivers/ | +84 | 0 replies | |
| 8/9 | IB/srp: Rename FMR-related variablesdrivers/ drivers/ | +38 | 0 replies | |
| 9/9 | IB/srp: Add fast registration supportdrivers/ drivers/ | +419 | 0 replies |
Reviews trailers per patch
6 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Sagi Grimberg |
|---|---|
| 1/9 | R-b |
| 2/9 | R-b |
| 3/9 | R-b |
| 4/9 | R-b |
| 5/9 | R-b |
| 6/9 | R-b |
| 7/9 | |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/9] SRP initiator patches for kernel 3.16
Changes compared to v3:
- Fixed test robot complaints ("undefined reference to `__udivdi3'" and "warning: format '%d' expects a matching 'int' argument").
- Restored support for HCA's that neither support FMR nor FR.
- Simplified memory registration pool reallocation code in srp_create_target_ib(). If FMR or FR is supported, an memory registration pool is allocated. If this fails, an error code is returned. If neither FMR nor FR is supported no attempt is made to allocate a memory registration pool.
- Minimized the changes in srp_add_one(). The decision to limit sg_tablesize is now based on whether or not the HCA supports memory registration instead of whether allocation of a memory registration pool succeeded. This change allows to keep the resource allocation order unmodified.
- Fixed a (theoretical ?) memory registration failure that was introduced in Linux kernel v2.6.39 (state->npages being compared against SRP_FMR_SIZE instead of max_pages_per_fmr).
Changes compared to v2:
- Reconnect to the SRP target if a local invalidation work request fails.
- Swapped the state->next_fmr / next_fr assignments to improve code readability.
- Clarified a comment in patch 1/9.
- Fixed error handling in srp_create_target() (was broken in v2).
- Added a missing "PFX" in two shost_printk() statements in patch 9/9.
Changes compared to v1:
- Modified the FMR code such that one FMR pool is allocated per connection instead of one pool per HCA.
- Dropped the patch "Make srp_alloc_req_data() reallocate request data".
- Moved introduction of the register_always kernel module parameter into a separate patch.
- Removed the loop from around ib_create_fmr_pool() and srp_create_fr_pool(). max_pages_per_mr is now computed from max_mr_size and max_fast_reg_page_list_len.
- Reduced fast registration pool size from 1024 to scsi_host->can_queue.
- Added a patch that should fix a crash that had been reported by Sagi but that I have not yet been able to reproduce myself.
This patch series consists of the following nine patches:
0001-IB-srp-Fix-a-sporadic-crash-triggered-by-cable-pulli.patch 0002-IB-srp-Fix-kernel-doc-warnings.patch 0003-IB-srp-Introduce-an-additional-local-variable.patch 0004-IB-srp-Introduce-srp_map_fmr.patch 0005-IB-srp-Introduce-srp_finish_mapping.patch 0006-IB-srp-Introduce-the-register_always-kernel-module-p.patch 0007-IB-srp-One-FMR-pool-per-SRP-connection.patch 0008-IB-srp-Rename-FMR-related-variables.patch 0009-IB-srp-Add-fast-registration-support.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html