ARM: VDSO
Get series with b4
b4 am CALCETrU-PwPqWtFK0gyW9eVgOMNRsfaXzaCKrrz0gN473dikbA@mail.gmail.comVersions newest first · linked by author and title
- v9 Latest posting 3/31 of 6 patches 0 repliesNew
- v9 posting 2/30 of 6 patches 0 repliesSuperseded
- v9 posting 1/30 of 6 patches 0 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 posting 2/2 | 8 of 9 patches | 0 replies | Superseded | |
| v7 posting 1/2 | 5 of 9 patches | 0 replies | Superseded |
1 of 6 patches is in this archive. The cover letter announces 6.
Patches in v9 posting 3/3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 4/6 | ARM: add vdso user-space code | +0 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.
Cover letter [PATCH v9 0/6] ARM: VDSO
Quoted 84 lines · Nathan Lynch
Quoted 67 lines · Andy Lutomirski
Quoted 57 lines · Nathan Lynch
Quoted 8 lines · Christopher Covington
It appears to me that there is code in several architecture subdirectories (I'm aware of x86, arm64, and with these patches arm[32] and I would be surprised if there weren't more) doing largely the same setup of special mappings at randomized offsets, checking ELF magic etc. Not that these patches should necessarily do it, but is there a reasonable amount of consolidation that could be done, or am I underestimating how much of this really does vary per architecture?
Sorry to not respond to this promptly, was distracted by some other work.
As Andy said, the possibility for consolidating some aspects of VDSO support is there, but it would be a fair bit of work.
For example,
arch_setup_additional_pagestends to have the general form of:lock
mmap_semget_unmapped_areainstall_special_mapping(or_install_special_mapping, preferably) stash vdso address in mmu context
releasemmap_semBut there are a lot of implementation details that differ:
+---------------------------------------------------------------- | Number of VMAs installed | +------------------------------------------------------------ | | Considers uses_interp | | +------------------------------------------------------ | | | Uses _install_special_mapping | | | +------------------------------------------------ | | | | Performs additional work (e.g. remap_pfn_range) | | | | +------------------------------------------ | | | | | Randomizes VDSO offset vs stack and libs | | | | | +------------------------------------ | | | | | | Records VDSO address in mmu context | | | | | | +------------------------------ | | | | | | | Supports compat VDSO | | | | | | | +------------------------ | | | | | | | | Supports disabling VDSO | | | | | | | | at boot (e.g. vdso=off) | | | | | | | | +------------------ | | | | | | | | | Can disable VDSO arch | | | | | | | | | via Kconfig ---------+---+-----+-----+-----+-----+-----+-----+-----+------------------ arm* | 3 | no | yes | no | yes | yes | no | no | yes arm64 | 2 | no | yes | no | no | yes | no | no | no hexagon | 1 | no | no | no | no | yes | no | no | no mips | 1 | no | no | no | no | yes | no | no | no powerpc | 1 | no | no | no | no | yes | yes | no | no s390 | 1 | yes | no | no | no | yes | yes | yes | no sh | 1 | no | no | no | no | yes | no | yes | yes tile | 1 | no | no | yes | no | yes | no | yes | no x86 | 2 | no | yes | yes | yes | yes | yes | yes | noQuoted 8 lines
* With VDSO patches from this thread, of course.
I think pushing the
mmap_semlock/unlock up into the ELF loader might be of some benefit (slightly reduced complexity in the arch code). But any generic replacement forarch_setup_additional_pageswill have to account for all the differences above, and probably a few more I've missed.Quoted 2 lines
Wow, nice table! I think that we should eventually get rid of most of these differences.
Thanks, and agreed.
Quoted 6 lines
Christopher, since you seem to be interested in CRIU, one thing to note is that any architecture that shoves a pointer to the vdso into the mmu context is likely to fail if the vdso is mremapped. CRIU needs to mremap the vdso, so this is a problem.
x86_64is an exception: it doesn't use that pointer for anything.Hmm, I would expect architectures that implement
arch_vma_namelike so to experience problems with CRIU:
Quoted 8 lines
const char *arch_vma_name(struct
vm_area_struct*vma){ if (vma->vm_mm && vma->vm_start == vma->vm_mm->context.vdso_base) return "[vdso]"; return NULL; }Is this what you're referring to?
I never entirely understood why this wasn't a bigger problem. I think it only really caused problems when checkpointing, restoring, checkpointing *again*, and getting unlucky.
Quoted 5 lines
Looking at 3.17-rc3, every arch uses
mm_context_t->vdso_baseor similar to provide a value forAT_SYSINFO_EHDRat exec time. Is this also problematic?
This one's fine, since it's very hard to mremap between mapping the vdso and having exec return.
The ones that are serious problems (on x86 32-bit userspace, at least) are the vdso sigreturn trampoline and, even worse, the vdso sysexit trampoline. The latter will cause every syscall on any native 32-bit system or on any 32-bit compat code running on an Intel CPU to segfault immediately upon mremapping the vdso.
--Andy