Skip to content

usb: ci_udc: fixes and cleanups

Jörg Krause u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 6 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/6] usb: ci_udc: fixes and cleanups
Quoted 17 lines · Stephen Warren

From: Stephen Warren <[email protected]>

This is a series of small fixes and cleanups either required by those fixes, or enabled now that the fixes are made.

I hope that either patch 1 or 4 might fix the issues J?rg is seeing, but I'm not sure that will happen. The other patches shouldn't change any behaviour.

Stephen Warren (6):
usb: ci_udc: fix ci_flush_{qh,qtd} calls in ci_udc_probe()
usb: ci_udc: don't assume QTDs are adjacent when transmitting ZLPs
usb: ci_udc: lift ilist size calculations to global scope
usb: ci_udc: fix items array size/stride calculation
usb: ci_udc: remove controller.items array
usb: ci_udc: don't memalign() struct ci_req allocations

Quoted 4 lines
  drivers/usb/gadget/ci_udc.c | 62 ++++++++++++++++++++++-----------------------
  drivers/usb/gadget/ci_udc.h |  1 -
  2 files changed, 30 insertions(+), 33 deletions(-)

Good news! The last patch usb: ci_udc: don't memalign() struct ci_req allocations removes the timeout error after starting the fourth run of tftp in a row.

This is how I tested. Checked out u-boot-usb/master branch. Applied the necessary patches to support our board. Applied the patches step after step. After applying a patch reset the board and run tftp from console until an error occured, which is always the fourth run. This is the case until applying patch usb: ci_udc: don't memalign() struct ci_req allocations, which throws no timeout error within running tftp about 60 times in a row.