always run all lint targets when running the test suite
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 0 repliesNew
- v12 patches 4 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | t/Makefile: check helper scripts for non-portable shell commands toot/ | +2 | 0 replies | |
| 2/2 | t/Makefile: always test all lint targets when running testst/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/2] always run all lint targets when running the test suite
Am 09.07.2014 07:42, schrieb Junio C Hamano:
Quoted 16 lines · Jens Lehmann
Quoted 8 lines
Am 07.07.2014 20:13, schrieb Junio C Hamano:
Quoted 2 lines
So I am not very enthusiastic to see this change myself.
Ok, I understand we do not want to lightly risk false positives. I just noticed that I accidentally forgot to sign off this series, so I'd resend just the first patch with a proper SOB, ok?
Nah, let's do both and how it plays out. My not being very enthusiastic myself does not necessarily mean that it is bad for the project. Maybe most people like it and if I cannot bear with it I can always turn it off myself for my environment.
Quoted 4 lines
I just have a strange feeling that we may be seeing some twisted shell script updates and when the author gets asked why it was written in such a strange way, the answer might turn out to be "just to work around the false positive from the test-lint", which I would not want to see.
Me neither. But until then it might well be that the benefit of having this test on by default outweighs this potential problem. It would have surely detected my fingers typing "echo -n" without my brain being alert enough to catch this portability issue ;-)
This is the updated version with proper SOBs and an updated commit message for 2/2 which is trying to sum up the considerations raised in this thread.
Jens Lehmann (2):
t/Makefile: check helper scripts for non-portable shell commands too t/Makefile: always test all lint targets when running tests
t/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.0.1.476.gf051ede