Skip to content

getcwd without PATH_MAX

René Scharfe git 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 16 repliesIn review
  2. v24 patches 4 repliesSuperseded

Changes in v3 from the cover letter

* all getcwd() calls are converted
* the two strbuf_getcwd() examples from last round use xgetcwd() now, as suggested by Jeff
* strbuf_add_absolute_path() is introduced

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10strbuf: add strbuf_getcwd()Documentation/technical/api-strbuf.txt strbuf.c strbuf.h+26 -00 replies
2/10unix-sockets: use strbuf_getcwd()unix-socket.c+7 -71 reply
3/10setup: convert setup_git_directory_gently_1 et al. to strbufsetup.c+43 -424 replies
4/10abspath: use strbuf_getcwd() to remember original working directoryabspath.c+5 -40 replies
4/10abspath: use strbuf_getcwd() to remember original working directoryabspath.c+5 -40 replies
5/10abspath: convert real_path_internal() to strbufabspath.c+25 -447 replies
6/10wrapper: add xgetcwd()git-compat-util.h wrapper.c+9 -00 replies
7/10use xgetcwd() to get the current directory or diebuiltin/init-db.c builtin/rev-parse.c dir.c +3 more+30 -260 replies
8/10use xgetcwd() to set $GIT_DIRbuiltin/init-db.c git.c+6 -60 replies
9/10abspath: convert absolute_path() to strbufDocumentation/technical/api-strbuf.txt abspath.c strbuf.c +1 more+37 -423 replies
10/10use strbuf_add_absolute_path() to add absolute pathsexec_cmd.c sha1_file.c+2 -60 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by.

PatchDuy NguyenJeff King
1/10Helped-by
2/10
3/10
4/10
4/10
5/10Noticed-by
6/10Helped-by
7/10
8/10
9/10Noticed-by
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/10] getcwd without PATH_MAX

Paths longer than PATH_MAX can be created and used on at least on some file systems. Currently we use getcwd() generally with a PATH_MAX- sized buffer. This series adds two functions, strbuf_getcwd() and xgetcwd(), then uses them to reduce the number of fixed-sized buffers and to allow us to handle longer working directory paths.

Changes in v3:
* all getcwd() calls are converted
* the two strbuf_getcwd() examples from last round use xgetcwd() now, as suggested by Jeff
* strbuf_add_absolute_path() is introduced

René Scharfe (10):
strbuf: add strbuf_getcwd()
unix-sockets: use strbuf_getcwd()
setup: convert setup_git_directory_gently_1 et al. to strbuf
abspath: use strbuf_getcwd() to remember original working directory
abspath: convert real_path_internal() to strbuf
wrapper: add xgetcwd()
use xgetcwd() to get the current directory or die
use xgetcwd() to set $GIT_DIR
abspath: convert absolute_path() to strbuf
use strbuf_add_absolute_path() to add absolute paths

 Documentation/technical/api-strbuf.txt |  10 +++
 abspath.c                              | 124 +++++++++------------------------
 builtin/init-db.c                      |  24 +++----
 builtin/rev-parse.c                    |   6 +-
 dir.c                                  |  12 ++--
 exec_cmd.c                             |   6 +-
 git-compat-util.h                      |   1 +
 git.c                                  |  13 ++--
 setup.c                                |  91 ++++++++++++------------
 sha1_file.c                            |   2 +-
 strbuf.c                               |  46 ++++++++++++
 strbuf.h                               |   3 +
 trace.c                                |   7 +-
 unix-socket.c                          |  14 ++--
 wrapper.c                              |   8 +++
 15 files changed, 190 insertions(+), 177 deletions(-)
Signature · 1 line
2.0.2