Skip to content

brd: partition fixes

Boaz Harrosh linux-fsdevel lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 7 repliesIn review
  2. v35 patches 11 repliesSuperseded
  3. v25 patches 13 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches13 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4axonram: Fix bug in direct_accessarch/powerpc/sysdev/axonram.c+1 -10 replies
2/4block: Change direct_access calling conventionDocumentation/filesystems/xip.txt arch/powerpc/sysdev/axonram.c drivers/block/brd.c +4 more+86 -580 replies
3/4brd: Fix all partitions BUGsdrivers/block/brd.c+38 -629 replies
4/4brd: Request from fdisk 4k alignmentdrivers/block/brd.c+9 -01 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchJan KaraMathieu DesnoyersBoaz HarroshRoss ZwislerMartin K. Petersen
1/4R-b R-b
2/4R-b R-b
3/4T-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCHSET 0/4 v4] brd: partition fixes

Jens Hi

Currently brd has multiple bugs when trying to use partitions. After this set all known problems are solved. Please see individual patch for description of the problem.
(Another merge window, another patchset send. I wish you would tell me to
just *uck-off, instead of this silence. What is so big a deal about this simple bug fixes.)

These should go into current v3.19-rcXX merge window they are real bugs solving Data corruption, when using partitions.

[v4]
- Rebase to 3.19-rc3
- Removed the getgeo patch it is no longer needed by new fdisk
- Minor change to patch: [4/4] brd: Request from fdisk 4k alignment As suggested by Martin

[v3]
Same exact code but some commit messages changed to try and explain better what was fixed and why. (Rebased on 3.18-rc3 but nothing changed in brd.c since then)

[v2]
Based on Jens's linux-next [30e996a] incorporating the brd patch by Dmitry Monakhov. Dmitry has introduced a new part_show parameter, this parameter is now removed and we always "part_show=1".
Scripts that did part_show=1 will work just the same but will display a message in logs. This is harmless. (And scripts can be modified to remove this parameter)

[v1]
Current situation is that any attempt to use partitions with brd device would create the partition but then any use will trash the data.

See: http://www.spinics.net/lists/linux-scsi/msg76737.html

So these patches fixes up all the problems we saw with the code, but not sacrificing any of the old fixtures. See [patch 3/4] for more explanations.

list of patches:
[PATCH 1/4] axonram: Fix bug in direct_access [PATCH 2/4] block: Change direct_access calling convention

These 2 above are from Matthew's DAX series latest version. Exactly as is, taken from the 01org/prd.git tree They are needed so to support direct_access with partitions.

[PATCH 3/4] brd: Fix all partitions BUGs

This one fixes all the very HARD bugs, which today cause data corruption.

[PATCH 4/4] brd: Request from fdisk 4k alignment

One can fetch/view these patches from a public tree here:
git: git://git.open-osd.org/pmem.git brd-partitions branch
web: http://git.open-osd.org/gitweb.cgi?p=pmem.git;a=shortlog;h=refs/heads/brd-partitions

Thanks
Boaz