toolchain: warn for unsafe library/header paths
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 12 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 12 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 00/12] toolchain: warn for unsafe library/header paths
[/me is back from too long holidays, facing 2000 BR mails :-)]
Quoted 28 lines · Yann E. MORIN
Thomas?, All,
On 2014-08-22 21:29 +0200, Thomas De Schampheleire spake thusly:
Quoted 11 lines
"Yann E. MORIN" <[email protected]> schreef:
Quoted 10 lines
Thomas, All,
On 2014-08-21 23:33 +0200, Thomas Petazzoni spake thusly:
Quoted 6 lines · Romain Naour
Quoted 2 lines
Also,
BR_COMPILER_PARANOID_UNSAFE_PATHneeds to be renamed toBR2_COMPILER_PARANOID_UNSAFE_PATHto follow the naming scheme ?No: BR2_* variables are Config.in options. Environment variables are BR_*.
Quoted 8 lines
Quoted 2 lines
Earlier this year in Brussels, we said we were to use
BR2_everywhere :
http://elinux.org/Buildroot:DeveloperDaysFOSDEM2014Hmm, that is written in the conclusion, but this is very
different than what is in the 'proposed rules'.
Was it really the final outcome to use BR2 for all types
of variable? I thought we wanted to make a distinction between config variables and others...Yes, I was a bit surprised by the conclusion, too. From what I remember, I thought we decided for:
- user-facing variables: prefix withBR2_
- internal variables: prefix withBR_
Quoted 6 lines
IIRC, we already have a few changesets implementing those rules.
For example:
35c666e toolchain/wrapper: renameBR_DEBUG_WRAPPER(I could not find another reverse such change, unfortunetely...)
Blame the reporter.
The conclusion was:
* BR2_ for all Kconfig variables;
* BR2_ for user-facing environment variables;
* BR_ for internal environment variables.
Other such changes:
4113b3c infra: replace BUILDROOT_CONFIG with BR2_CONFIG 6768021 infra: replace BUILDROOT_DL_DIR with BR2_DL_DIR.
Regards,
Arnout
Quoted 4 lines
Regards,
Yann E. MORIN.
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F