mmc: EXT_CSD_PARTITION_SETTING_COMPLETED bit not checked
Status from this message: Thanks! Applied for next.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 3 repliesApplied
- v53 patches 1 replySuperseded
- v43 patches 1 replySuperseded
Changelog v5 from the cover letter
Remove some useless braces
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | mmc: Move code that manages user area and gp partitions into functionsdrivers/ | +89 | 1 reply | |
| 2/3 | mmc: Replace "enhanced_area_en" attribute by "partition_setting_completed"drivers/ include/ include/ | +11 | 1 reply | |
| 3/3 | mmc: Checks EXT_CSD_PARTITION_SETTING_COMPLETED before partitions computationdrivers/ | +44 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.
Cover letter [PATCH v6 0000/0003] mmc: EXT_CSD_PARTITION_SETTING_COMPLETED bit not checked
JEDEC standard requires that EXT_CSD_PARTITION_SETTING_COMPLETED bit must be set in order to take in account enhanced area and general purpose partitions (gp) values.
Current code doesn't checks this bit and blindly trust enhanced area and gp values. Moreover, "enhanced_area_en" attribute was set according to gp values but not necessary enhanced area one. It's then used to switch EXT_CSD_ERASE_GROUP_DEF bit which requires EXT_CSD_PARTITION_SETTING_COMPLETED. This attribute has been replaced by "partition_setting_completed" that match the expected behavior.
User is now warned in case of misconfiguration.
Plus, some code has been moved into functions for two reasons :
* Functional reason (one behavior per function)
* Deep indentation result
Grégory Soutadé (3):
mmc: Move code that manages user area and gp partitions into functions
mmc: Replace "enhanced_area_en" attribute by "partition_setting_completed"
mmc: Checks EXT_CSD_PARTITION_SETTING_COMPLETED before partitions computation
drivers/mmc/core/mmc.c | 172 ++++++++++++++++++++++++++-------------------- include/linux/mmc/card.h | 2 +- include/linux/mmc/mmc.h | 2 + 3 files changed, 102 insertions(+), 74 deletions(-)
From commit 7ec62d421bdf29cb31101ae2689f7f3a9906289a in master linux tree.
Changelog v5:
Remove some useless braces
Changelog v4:
Second patch in v3 doesn't compile
Changelog v3:
Move code BEFORE fixing bugs.
Changelog v2:
Move code for user area and general purpose partitions into functions.
Signature · 1 line
1.7.9.5