IB/srp: Add multichannel support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 of 11 patches 4 repliesIn review
- v1 RFC4 of 8 patches 14 repliesSuperseded
Changes in v3 from the cover letter
* Eliminated the new function blk_mq_build_unique_tag() from patch 1.
* Elaborated the nr_hw_queues documentation in patch 2 as requested by Martin.
* Merged patches v2/10 and v2/11 into a single patch (v3/9).
* Removed a debug statement from the patch that adds multichannel support, and added another new debug statement (WARN_ON_ONCE(scmnd->request->tag < 0) in srp_queuecommand()).
* Added a new patch (v3/11) that fixes a recently reported race condition. Although that patch is unrelated to adding multichannel support, that patch has been added to this series to avoid merge conflicts by submitting patches for the same driver to different maintainers.
7 of 11 patches are in this archive. The cover letter announces 11.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 2/11 | scsi-mq: Add support for multiple hardware queuesdrivers/ include/ | +9 | 0 replies | |
| 3/11 | scsi_tcq.h: Add support for multiple hardware queuesinclude/ | +11 | 0 replies | |
| 4/11 | IB/srp: Move ib_destroy_cm_id() call into srp_free_ch_ib()drivers/ | +6 | 0 replies | |
| 5/11 | IB/srp: Remove stale connection retry mechanismdrivers/ | +3 | 0 replies | |
| 6/11 | IB/srp: Avoid that I/O hangs due to a cable pull during LUN scanningdrivers/ drivers/ | +52 | 1 reply | |
| 8/11 | IB/srp: Separate target and channel variablesdrivers/ drivers/ | +403 | 0 replies | |
| 11/11 | IB/srp: Fix a race condition triggered by destroying a queue pairdrivers/ drivers/ | +52 | 3 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jens Axboe | Sagi Grimberg | Martin K. Petersen |
|---|---|---|---|
| Series | A-b | R-b R-b R-b | R-b |
| 2/11 | R-b | R-b | |
| 3/11 | R-b | ||
| 4/11 | R-b | ||
| 5/11 | R-b | ||
| 6/11 | R-b | ||
| 8/11 | A-b | ||
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/11] IB/srp: Add multichannel support
Although the SRP protocol supports multichannel operation, although since considerable time RDMA HCA's are available that support multiple completion vectors and although multichannel operation yields better performance than using a single channel, the Linux SRP initiator does not yet support multichannel operation. Hence this patch series that adds multichannel support to the SRP initiator driver.
Changes between v2 and v3:
* Eliminated the new function blk_mq_build_unique_tag() from patch 1.
* Elaborated the nr_hw_queues documentation in patch 2 as requested by Martin.
* Merged patches v2/10 and v2/11 into a single patch (v3/9).
* Removed a debug statement from the patch that adds multichannel support, and added another new debug statement (WARN_ON_ONCE(scmnd->request->tag < 0) in srp_queuecommand()).
* Added a new patch (v3/11) that fixes a recently reported race condition. Although that patch is unrelated to adding multichannel support, that patch has been added to this series to avoid merge conflicts by submitting patches for the same driver to different maintainers.
Changes between v1 and v2:
* Added a function to the block layer that allows SCSI LLDs to query the blk-mq hardware context index chosen by the block layer. Removed the mq_queuecommand callback again.
* Added support for multiple hardware queues in the TCQ functions in the SCSI core.
* Split a few patches and elaborated the patch descriptions to make it easier to review this patch series.
* Added two new patches: one patch that makes the SRP initiator always use block layer tags and another patch that realizes a micro- optimization, namely elimination of the free requests list.
The patches in this series are:
0001-blk-mq-Add-blk_mq_unique_tag.patch 0002-scsi-mq-Add-support-for-multiple-hardware-queues.patch 0003-scsi_tcq.h-Add-support-for-multiple-hardware-queues.patch 0004-IB-srp-Move-ib_destroy_cm_id-call-into-srp_free_ch_i.patch 0005-IB-srp-Remove-stale-connection-retry-mechanism.patch 0006-IB-srp-Avoid-that-I-O-hangs-due-to-a-cable-pull-duri.patch 0007-IB-srp-Introduce-two-new-srp_target_port-member-vari.patch 0008-IB-srp-Separate-target-and-channel-variables.patch 0009-IB-srp-Use-block-layer-tags.patch 0010-IB-srp-Add-multichannel-support.patch 0011-IB-srp-Fix-a-race-condition-triggered-by-destroying-.patch