Skip to content

Make Armada 375 use the reference clock when possible

Gregory CLEMENT linux-arm-kernel linux-watchdog 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 of 4 patches 0 repliesNew

1 of 4 patches is in this archive. The cover letter announces 4.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4clocksource: armada-370-xp: Add missing clock enable+0 -00 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchGregory CLEMENT
1/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Make Armada 375 use the reference clock when possible

Hi Ezequiel,

Quoted 3 lines · Ezequiel Garcia

This series adds support for the 25 MHz reference clock available on Armada 375 SoC to use on the timer and watchdog drivers. It is similar to the one present in Armada XP SoC.

I agree with Thomas P. comments: could you see if it was possible to reuse the same function and dt bindings that the ones used for Armada XP ?
I am not aware of any difference between Armada XP and Armada 375 for this IP.

Thanks,

Gregory

Quoted 27 lines

Given we initially had access to only a very early SoC revision (A375 Z0) and due to a hardware issue, the timer and watchdog support was originally submitted to use the core clock.

Now that the A0 SoC revision is out, we can fix this and use the reference clock. The reason for this change is that the core clock is subject to the SSCG, so boards where SSCG is enabled exhibit a very large timer drift.

To prevent any compatibility issues when booting with an older devicetree, this series provides proper fall backs in each case.

The series applies on v3.18-rc1. As usual, any feedback is well received!

Ezequiel Garcia (4):
clocksource: armada-370-xp: Add missing clock enable
watchdog: orion: Use the reference clock on Armada 375 SoC
clocksource: armada-370-xp: Use the reference clock on A375 SoC
ARM: dts: Enable the reference clock for timer and watchdog on Armada

    375 SoC
 .../bindings/timer/marvell,armada-370-xp-timer.txt |  9 +++--
 arch/arm/boot/dts/armada-375.dtsi                  | 12 +++++--
 drivers/clocksource/time-armada-370-xp.c           | 30 ++++++++++++++++
 drivers/watchdog/orion_wdt.c                       | 40 +++++++++++++++++++++-
 4 files changed, 86 insertions(+), 5 deletions(-)
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com