scsi_debug: switch to table based parser
Status from this message: Thanks, applied the whole series to drivers-for-3.19. I also switched
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 11 repliesApplied
- v11 patch 2 repliesSuperseded
Changes in v2 from the cover letter
- break single big patch into 4 smaller ones and one less large
- resync with drivers-for-3.19
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | scsi_debug: pinpoint invalid field in sense datadrivers/ | +88 | 1 reply | |
| 2/5 | scsi_debug: append inject error flags onto scsi_cmnd objectdrivers/ | +68 | 1 reply | |
| 3/5 | scsi_debug: add Capacity Changed Unit Attentiondrivers/ | +24 | 2 replies | |
| 4/5 | scsi_debug: change SCSI command parser to table drivendrivers/ | +833 | 5 replies | |
| 5/5 | scsi_debug: Add Report supported opcodes+tmfs; Compare and writedrivers/ | +307 | 1 reply |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Hannes Reinecke |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] scsi_debug: switch to table based parser
This series of patches is in response to Hannes' comments earlier today. He wanted the single large patch broken up.
Changes since v1:
- break single big patch into 4 smaller ones and one less large
- resync with drivers-for-3.19
Patches:
[PATCH v2 1/5] pinpoint invalid field in sense data [PATCH v2 2/5] append inject error flags onto scsi_cmnd object [PATCH v2 3/5] add Capacity Changed Unit Attention [PATCH v2 4/5] change SCSI command parser to table driven [PATCH v2 5/5] Add Report supported opcodes+tmfs; Compare and write
Todo:
- re-order teardown in scsi_debug_exit()
- make sdebug_dev_info::stopped atomic (add to end of uas_bm ?)
- review Rob Elliott's suggestions; look at speed ups
- remove host_lock logic and make the host_lock option a dummy
- update some mode page and VPD data to reflect more recent devices
- changing remaining >> and << byte handling over to
get/put_unaligned_be*()
- set INFO field for COMPARE AND WRITE command MISCOMPAREs
Hannes also asked that XDWRITEREAD_10 be added to scsi.h . It has been there for a while. I guess he meant something else.