Skip to content

debugfs: adding helper for single seq_file

Arend van Spriel ath9k-devel linux-wireless 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/20 of 3 patches 0 repliesNew
  2. v2 posting 1/23 patches 0 repliesSuperseded
  3. v10 of 3 patches 0 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [ath9k-devel] [PATCH V2 0/3] debugfs: adding helper for single seq_file
Quoted 15 lines · Arend van Spriel

This series replaces the initial series posted:

Message-ID:<[email protected]>

This series include changes in driver code to investigate potential code savings. As example used the ath9k driver as it has a fair amount of debugfs files. In this series it changes 7 debugfs entries to use seq_file and the helper function. Below the output of the size utility:

    text	   data	    bss	    dec	    hex	filename
  115968	   1225	     28	 117221	  1c9e5	original/ath9k.o
  113224	   1225	     28	 114477	  1bf2d	seq_file/ath9k.o
  111024	   1225	     28	 112277	  1b695	helper/ath9k.o
Quoted 5 lines

This series is for 3.19 kernel and applies to the driver-core-next branch of the driver-core repository.

The second patch has a number of CamelCase checks, but those were already present in code. So fixing that would be a separate effort.

Hi Greg,

These patches did not show up in driver-core repo so did you miss them. If I need to rebase again, let me know.

Regards,
Arend

Quoted 21 lines

Changelog:
----------
V2:
- fixed whitespace failures.
- use seq_puts where applicable.
- rebased on driver-core-next branch.

Arend van Spriel (3):
debugfs: add helper function to create device related seq_file
ath: use seq_file api for ath9k debugfs files
ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file
entries

  drivers/net/wireless/ath/ath9k/ahb.c   |   1 +
  drivers/net/wireless/ath/ath9k/debug.c | 459 +++++++++++----------------------
  drivers/net/wireless/ath/ath9k/debug.h |  11 +-
  drivers/net/wireless/ath/ath9k/pci.c   |   1 +
  fs/debugfs/file.c                      |  54 ++++
  include/linux/debugfs.h                |  16 +-
  6 files changed, 226 insertions(+), 316 deletions(-)

Read the cover letter in its thread