PL01x: baudrate & line control fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 5 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 0/5] PL01x: baudrate & line control fixes
Hello Simon,
Quoted 51 lines · Simon Glass
Hi Vikas,
Quoted 48 lines · vikasm
Hi Simon,
Quoted 23 lines · Simon Glass
Hi Vikas,
Quoted 20 lines · vikasm
Thanks Simon,
Quoted 16 lines · Simon Glass
Hi Vikas,
Quoted 13 lines · Vikas Manocha
This patchset fixes the pl01x driver esp for pl011 baudrate & line control.
Vikas Manocha (5):
serial: pl01x: passpl01x_typeto set baudrate
serial: pl01x: fix pl011 baud rate configuration
serial: pl01x: move all line control at same place
serial: pl01x: disable as per type of pl01x
serial: pl01x: avoid pl01x type check two times
drivers/serial/serial_pl01x.c| 46
+++++++++++++++++++++--------------------1 file changed, 24 insertions(+), 22 deletions(-)Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Great to see this series. If you have not tested on p1010 I can do this in a week or so (am travelling). At least a few of these looks like bug fixes to my recent refactor so I could bring them through the DM tree if no one else picks them up.
I was able to test it only for pl011, don't have any board with pl010.
Sadly I was wrong, I only have pl011 also. It makes me wonder how it worked so nicely for me without your patches.
Please find below the possible explanation for all patches:
serial: pl01x: pass
pl01x_typeto set baudrate
- This patch only affect if DM is not defined.
If you are using driver model for pl011, pl011 will work without this patch.serial: pl01x: fix pl011 baud rate configuration
- If pl011 is already configured to correct baudrate or LCR register is being written later.serial: pl01x: move all line control at same place
- this patch does not affect the functionality.
Quoted 7 lines
Quoted 6 lines
serial: pl01x: disable as per type of pl01x
- pl011 might work without disabling it properly at start. pl010 control register(disable bit) location is reserved in case of pl011.serial: pl01x: avoid pl01x type check two times
- does not affect the functionality.I didn't mean for you to go to that much trouble, but thank you.
Not a problem, i was also curious to know it.
Quoted 4 lines
Raspberry Pi is running without driver model (I tested it both ways) so I guess I'm just lucky (or actually unlucky since I might have noticed these problems).
just guessing... (don't want to bother you....don't reply if is not the case)
could it be possible uart is already initialized before u-boot like in xloader if it exists for Raspberry....
Quoted 3 lines
When Stephen ACKs my Raspberry Pi driver rmodel series then I'll pull this series in to DM.
ok.
Quoted 3 lines
Regards,
Simon
Regards,
Vikas