irqchip: kill the GIC routable domain
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 5 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] irqchip: kill the GIC routable domain
Quoted 3 lines · Nishanth Menon
Anyways.. The following diff[1] on top of your branch makes DRA7 work - I assume you will squash as needed and repost with linux-omap mailing list in CC.
Brilliant. I'll squash that into my tree and repost at some point.
Quoted 11 lines
I increased the scope of testing knowing that WUGEN is present in many A9 based TI platforms as well.. and at least OMAP4 showed flakiness in my testing.. Also a few notes:
Stuff like: am437x is a bit questionable (interrupt-parent probably should be wugen?)
175: 0 GIC 39 tps65218OMAP5: (should be wugen?)
308: 4323 0 GIC 106 OMAP UART2 411: 0 0 GIC 151 twl6040 405: 1 0 GIC 39 palmas
Well, I can't really tell. Someone with access to the documentation should be able to find out.
Quoted 3 lines
OMAP4 serial port is flaky -> not sure if it is due to routing of GIC to UART2 and not via WUGEN IRQ branch: with my fix applied:
---------------------------------
[...]
Quoted 2 lines
18: pandaboard-es: Boot FAIL: http://slexy.org/raw/s20ty0Z6i5 (not expected) 19: pandaboard-vanilla: Boot FAIL: http://slexy.org/raw/s20BYfaMd2 (not expected)
If I read the log correctly, the serial port stops responding after a while?
[...]
Quoted 3 lines
I suggest skipping 3.19 if possible and giving it a more detailed time in linux-next with omap4 etc being more thoroughly being tested before letting it through, if possible.
None of that code is for 3.19 (that ship has sailed a long time ago). My plan is to hit 3.20, so it should be in -next by -rc4 or so.
Quoted 11 lines
[1] ------------- diff ------------
arch/arm/boot/dts/dra7-evm.dts | 2 +- arch/arm/boot/dts/dra7.dtsi | 23 +++++++++++++---------- drivers/irqchip/irq-crossbar.c | 4 ++-- 3 files changed, 16 insertions(+), 13 deletions(-)arch/arm/boot/dts/dra7-evm.dts +0
-0
arch/arm/boot/dts/dra7-evm.dts line 328
Quoted 7 lines
arch/arm/boot/dts/dra7-evm.dts +1
-1@@ -323,7 +323,7 @@ status = "okay"; pinctrl-names = "default"; pinctrl-0 = <&uart1_pins>; - interrupts-extended = <&gic GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended = <&crossbar_mpu GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>, <&dra7_pmx_core 0x3e0>; };
Ah, I obviously missed quite a few of these...
[...]
Quoted 14 lines
drivers/irqchip/irq-crossbar.c +1
-1@@ -99,7 +99,7 @@ static int allocate_gic_irq(struct irq_domain *domain, unsigned virq,if (err) cb->irq_map[i] =IRQ_FREE ;else - cb->write (hwirq, i); + cb->write (i, hwirq);return err; }
drivers/irqchip/irq-crossbar.c static int __init irqcrossbar_init(struct device_node *node, · line 356
Quoted 5 lines
drivers/irqchip/irq-crossbar.c +1
-1@@ -353,4 +353,4 @@ static int __init irqcrossbar_init(struct device_node *node,return 0 ; } -IRQCHIP_DECLARE (ti_irqcrossbar,"ti,irqcrossbar" , irqcrossbar_init); +IRQCHIP_DECLARE (ti_irqcrossbar,"ti,irq-crossbar" , irqcrossbar_init);
Ah, nice catch. Thanks a lot for the testing and the fixes. I'll try to get a panda up and running (I'm sure I have one collecting dust somewhere), and see if I can get it to behave.
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...