Skip to content

GICv3: add 32bit compatibility

Marc Zyngier linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 of 4 patches 0 repliesNew

2 of 4 patches are in this archive. The cover letter announces 4.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
4/4ARM: add 32bit support to GICv3+0 -01 reply
4/4ARM: add 32bit support to GICv3+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] GICv3: add 32bit compatibility

On 11/12/14 14:23, Jean-Philippe Brucker wrote:

Hi Jean-Philippe,

Quoted 11 lines

This series adds 32bit compatibility to Marc's GICv3 driver. Only SGIs, PPIs and SPIs support is present. No ITS nor virtualisation.

It is based on 3.18.

Jean-Philippe Brucker (4):
arm64: GICv3: refactor the AArch64 specific parts
arm64: GICv3: change unsigned types for AArch32 compatibility
arm64: GICv3: Specialize readq and writeq accesses
ARM: add 32bit support to GICv3

Quoted 8 lines
 arch/arm/include/asm/arch_gicv3.h   | 182 ++++++++++++++++++++++++++++++++++++
 arch/arm64/include/asm/arch_gicv3.h | 141 ++++++++++++++++++++++++++++
 drivers/irqchip/irq-gic-v3.c        |  69 ++++----------
 include/linux/irqchip/arm-gic-v3.h  |  95 +++----------------
 4 files changed, 356 insertions(+), 131 deletions(-)
 create mode 100644 arch/arm/include/asm/arch_gicv3.h
 create mode 100644 arch/arm64/include/asm/arch_gicv3.h

Overall, this looks good to me (once you've sorted the nits spotted by Russell). It is going to conflict quite badly with what is going to be merged in 3.19 though. Any chance you could rebase it on top of -rc1 once it is out?

Also, I don't see an obvious way to select CONFIG_ARM_GIC_V3 for ARM (arm64 selects it automatically). What about selecting it from ARCH_VIRT, which is likely to be the primary user of this?

Thanks,

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...