Skip to content

nvme-blkmq fixes

Jens Axboe linux-nvme 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] nvme-blkmq fixes
Quoted 17 lines · Keith Busch

Review static void req_completion(struct nvme_queue · line 439

Quoted 10 lines · Keith Busch
(quoted diff) +2 -1
@@ -432,7 +432,8 @@ static void req_completion(struct nvme_queue
 *nvmeq, void *ctx,
        if (!(status & NVME_SC_DNR || blk_noretry_request(req))
            && (jiffies - req->start_time) < req->timeout) {
            blk_mq_requeue_request(req);
-            blk_mq_kick_requeue_list(req->q);
+            if (!blk_queue_stopped(req->q))
+                blk_mq_kick_requeue_list(req->q);
            return;
        }

Oops, experimenting with different things, took the wrong snapshot of the patch. Should be:

+ if (nvmeq->cq_vector != -1)

Quoted 7 lines

rather than:

+ if (!blk_queue_stopped(req->q))

Anyway, I'm going to keep messing with this until I can either hit the other failures I mentioned or convince myself it's safe before sending something for official consideration.

I was puzzled by the signed change for cq_vector by itself. I'll wait on more results from you before doing anything.

Signature · 1 line
Jens Axboe

Read the cover letter in its thread