Second attempt at blk-mq + nvme hotplug fixes
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest2 of 10 patches 0 repliesNew
2 of 10 patches are in this archive. The cover letter announces 10.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | blk-mq: Wake tasks entering queue on dying | +0 | 0 replies | |
| 5/10 | blk-mq: Allow requests to never expire | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCHv2 00/10] Second attempt at blk-mq + nvme hotplug fixes
Quoted 15 lines · Keith Busch
Quoted 14 lines · Jens Axboe
Quoted 13 lines · Keith Busch
Second try, this time tested against many more scenarios than before with error injection and surprise hot-removal and intermittent resets.
I'm adding a lot of stuff outside the driver, but I didn't find a cleaner way to a lot of these things. This makes me a little nervous, so please let me know if anything seems amiss here. I don't think any of the blk-mq changes could possibly be harmful to anyone else since nvme is the only driver that uses most of the additions.
The only issue remaining I found is unfreezing queues might tigger the
percpu_ref_reinitWARN_ON_ONCEwhen the driver restarts arequest_queuewith queued up IO's.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
This is against linux-block/for-next.
Series looks sane to me, apart from the timeout change I replied to separately. Could you turn that into a request flag and respin the series on top of that?
Thanks a bunch, I'll respin the series with the no-timeout request flag, correct irq spin locking I found in [8/10], and fix attribution in [4/10].
Awesome, thanks Keith! And thanks for taking the time to get this sorted.
Signature · 1 line
Jens Axboe