Skip to content

video: Support for SSD2828 (parallel LCD to MIPI bridge)

Hans de Goede u-boot 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest0 of 7 patches 0 repliesNew
  2. v11 of 8 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 0/7] video: Support for SSD2828 (parallel LCD to MIPI bridge)

Hi,

Quoted 12 lines · Siarhei Siamashka

This is the v2 of

     http://lists.denx.de/pipermail/u-boot/2015-January/200807.html

It addresses the review comments.

One other change is the introduction of CONFIG_VIDEO_LCD_SSD2828_TX_CLK option. The Allwinner A20 reference tablet schematics suggests the use of 12MHz for 'tx_clk'. But the MSI Primo81 tablet has it as 27MHz. So it can be indeed different in different devices and deserves a config option. The patch "video: sunxi: Switch from 'tx_clk' to 'pclk' for SSD2828" had been dropped, because the Kconfig option makes it unnecessary.

Quoted 5 lines

Other than MSI Primo81, there is at least one more tablet with SSD2828:
http://linux-sunxi.org/ICOU_Fatty_I
Inspecting Android kernel sources indicates that two more GPIO pins are needed to support it. These changes can be submitted as a separate patchset later.

Thanks for doing a v2 of this.

I've queued up 1-6 with Anatolij's original acks where applicable in u-boot-sunxi/next. I've not queued up 7/7:
"video: ssd2828: Use MIPI DCS commands to retrieve the LCD panel id"

As I'm still not 100% sold on this, I believe you've made it safe now, but it still feels like needless chatter during boot on already supported boards. So I would personally prefer to see it all under a #ifdef DEBUG conditional. But since this now is a generic video chip driver it is not my call :)

Anatolij can you please let us know what you think of 7/7:
"video: ssd2828: Use MIPI DCS commands to retrieve the LCD panel id"

If you like it as is, I'll add it to u-boot-sunxi/next, where the others have already been merged.

Regards,

Hans

Quoted 26 lines

Siarhei Siamashka (7):
sunxi: axp221: Add ELDO[1-3] support
include: Add header file with MIPI DSI constants from linux 3.18
video: Add support for SSD2828 (parallel LCD to MIPI bridge)
video: sunxi: Hook up SSD2828 with the sunxi video driver
sun6i: Add LCD display support for MSI Primo81 tablet
video: ssd2828: Allow using 'pclk' as the PLL clock source
video: ssd2828: Use MIPI DCS commands to retrieve the LCD panel id

  board/sunxi/Kconfig           |   7 +
  board/sunxi/board.c           |   1 +
  configs/MSI_Primo81_defconfig |  10 +
  drivers/power/Kconfig         |  10 +
  drivers/power/axp221.c        |  33 +++
  drivers/video/Kconfig         |  72 ++++++
  drivers/video/Makefile        |   1 +
  drivers/video/ssd2828.c       | 578 ++++++++++++++++++++++++++++++++++++++++++
  drivers/video/ssd2828.h       | 128 ++++++++++
  drivers/video/sunxi_display.c |  38 +++
  include/axp221.h              |   7 +
  include/mipi_display.h        | 130 ++++++++++
  12 files changed, 1015 insertions(+)

create mode 100644 drivers/video/ssd2828.c
create mode 100644 drivers/video/ssd2828.h
create mode 100644 include/mipi_display.h

Read the cover letter in its thread