Skip to content

tools: checkman.sh portability

JWP util-linux 1 version Applied

Status from this message: Merged, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4tools: checkman.sh portabilitytools/checkmans.sh+12 -140 replies
2/4tools: checkman.sh portability lexgrogtools/checkmans.sh+21 -50 replies
3/4tools: checkmans.sh clean up 'let'tools/checkmans.sh+4 -100 replies
4/4tools: checkmans.sh add statstools/checkmans.sh+22 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] tools: checkman.sh portability

So, Sami Kerola's checkmans.sh tool caught me stuttering in hwclock.8 and I had to find out why checkmans did not work on my system:

1) Any test file with 'git' or 'lib' in its path fails. Including my entire repo under $PATH/github/util-linux and the ./lib/terminal-colors.d.5 man-page.

2) It depends on the man-db package.

The changes seem to be an improvement as it detected 4 new man-page problems (see separate patch).

I did alter the behavior slightly, previously failed pages required checking them again manually. Now it shows the troff parsing errors in progress. When grog fails there is nothing more to check, and when lexgrog fails I left the old behavior telling the caller to rerun the command, because I did not bother to install man-db to see what lexgrog actually does.

The following changes since commit 2e5bf10e32b00c92a3f7fb8b38d793ea6fc1dff2:

build-sys: add sfdisk.static (2015-01-13 16:59:03 +0100)

are available in the git repository at:

[email protected]:jwpi/util-linux.git checkman

J William Piggott (4):
tools: checkman.sh portability
tools: checkman.sh portability lexgrog
tools: checkmans.sh clean up 'let'
tools: checkmans.sh add stats

 tools/checkmans.sh | 85 +++++++++++++++++++++++++++++++++---------------------
 1 file changed, 52 insertions(+), 33 deletions(-)