Skip to content

Driver for TI tlc591xx 8/16 Channel i2c LED driver

Tomi Valkeinen linux-arm-kernel linux-devicetree linux-leds 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest posting 2/20 of 2 patches 0 repliesNew
  2. v6 posting 1/20 of 2 patches 0 repliesSuperseded
  3. v52 patches 0 repliesSuperseded

Patches in v6 posting 2/2 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCHv6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver
Quoted 16 lines · Andrew Lunn
Quoted 15 lines · Tomi Valkeinen
Quoted 11 lines · Andrew Lunn
Quoted 5 lines · Andrew Lunn

This patchset is a driver for the TI tlc59116 16 Channel i2c LED driver and tlc59108 8 Channel i2c LED driver. This driver is used on the Belkin WRT1900AC access point and the C code is derived from code Belkin contributed to OpenWRT. However it has been extensively re-written, and a device tree binding added to replace platform data.

Hi Bryan

Do you have any further comments on this driver? Are you likely to queue it up for the next merge window?

Hi Andrew,

Quoted 8 lines
Quoted 2 lines

You didn't comment anything on my and Peter's questions on v5 thread about this being a PWM driver.

Hi Tomi

I don't comment, because it is not our decision to make any more. We have been around this argument many times, so we are not going to resolve it. The LED and PWM maintainers need to decide, not us.

Well, I wasn't asking for decisions. I asked what are the technical differences between the options. If this driver would be implemented as a PWM driver, and you'd use pwm-leds, how would that affect your use case?

If I'm not mistaken, the only argument so far you've given was that the device cannot implement the pwm_config() call correctly, but Peter argued that it doesn't matter, other PWM devices cannot do that either.

I want the driver to work for all the users, and as I'm not that familiar with leds and pwms I need to ask these questions.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150209/fad2fcb2/attachment.sig>