qla2xxx: Fix various warnings reported by static source code analysis tools
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest10 patches 3 repliesIn review
- v210 patches 2 repliesSuperseded
- v110 patches 6 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | qla2xxx: Report both rsp_info and rsp_info_lendrivers/ | +2 | 0 replies | |
| 2/10 | qla2xxx: Declare local functions staticdrivers/ drivers/ drivers/ +1 more | +6 | 0 replies | |
| 3/10 | qla2xxx: Remove set-but-not-used variablesdrivers/ drivers/ drivers/ +11 more | +32 | 0 replies | |
| 4/10 | qla2xxx: Replace two macros with an inline functiondrivers/ drivers/ drivers/ | +15 | 0 replies | |
| 5/10 | qla2xxx: Remove __constant_ prefixdrivers/ drivers/ drivers/ +7 more | +231 | 1 reply | |
| 6/10 | qla2xxx: Avoid that sparse complains about duplicate [noderef] attributesdrivers/ drivers/ drivers/ | +4 | 0 replies | |
| 7/10 | qla2xxx: Fix sparse annotationsdrivers/ drivers/ drivers/ +3 more | +71 | 0 replies | |
| 8/10 | qla2xxx: Remove a superfluous testdrivers/ | +1 | 0 replies | |
| 9/10 | qla2xxx: Remove dead codedrivers/ | +5 | 0 replies | |
| 10/10 | qla2xxx: Avoid that sparse complains about context imbalancesdrivers/ drivers/ drivers/ +1 more | +52 | 1 reply |
Reviews trailers per patch
9 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Himanshu Madhani |
|---|---|
| Series | A-b |
| 1/10 | A-b |
| 2/10 | A-b |
| 3/10 | A-b |
| 4/10 | A-b |
| 5/10 | A-b |
| 6/10 | A-b |
| 7/10 | A-b |
| 8/10 | A-b |
| 9/10 | A-b |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/10] qla2xxx: Fix various warnings reported by static source code analysis tools
This patch series addresses several warnings reported by static source code analysis tools for the qla2xxx driver (gcc (W=1), sparse (C=2) and smatch (C=2 CHECK="smatch -p=kernel")). The patches in this series are:
0001-qla2xxx-Report-both-rsp_info-and-rsp_info_len.patch 0002-qla2xxx-Declare-local-functions-static.patch 0003-qla2xxx-Remove-set-but-not-used-variables.patch 0004-qla2xxx-Replace-two-macros-with-an-inline-function.patch 0005-qla2xxx-Remove-__constant_-prefix.patch 0006-qla2xxx-Avoid-that-sparse-complains-about-duplicate-.patch 0007-qla2xxx-Fix-sparse-annotations.patch 0008-qla2xxx-Remove-a-superfluous-test.patch 0009-qla2xxx-Remove-dead-code.patch 0010-qla2xxx-Avoid-that-sparse-complains-about-context-im.patch
Version 3 is a resend of the patches from v2 that are not yet upstream.
The changes compared to v1 of this series are:
- Rebased this patch series onto kernel v4.1-rc6.
- Also removed variable 'd2' in patch 3.
- Also remove the recently introduced dead code in patch 10.