common lcd refactor
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest0 of 13 patches 0 repliesNew
Patches in v2 No applies recorded yet
None of the 13 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Josh Wu |
|---|---|
| Series | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [PATCH V2 00/13] common lcd refactor
Hi, Nikita
Quoted 65 lines · Nikita Kiryanov
This series is part of my ongoing efforts to cleanup common/lcd code (and at some point merge it with the
CONFIG_VIDEOcode).
This series focuses on eliminating platform specific #defines fromlcd.ccode, and then adds a few platform independent code refactors and cleanups on top of that. A small note on the series:- The patch "lcd: split
configuration_get_cmap" turned out to be a little
problematic: the goal was to move all platform specific code to the appropriate lcd/fb drivers, and keep the generic case inlcd.cas a weak function. This was not possible to do forconfiguration_get_cmap(), because the weak version still has to compile even if it is overridden, and unfortunately the generic case referencespanel_info, which is a struct that varies depending on the configuration, and does not always have a cmap field. This demonstrated that the visibility ofpanel_infoshould be reviewed, and that there might be a need for some kind oflcd_genericdriver.
Since this may warrant a series of its own, I opted to tentatively implement the genericconfiguration_get_cmap()function inlcd.has static function, and plan to revisit it in the next series.The end result was compile tested on arm and powerpc, and tested on
cm_t35(splash screen feature). Rebased on current mainline.Changes in V2:
- Minor commit message changes (such as s/platform specific/platform-specific/,
s/Raspberry Pi config file is updated to compile the new file/Raspberry Pi is updated to accommodate the changes/)
- patch 2: defineconfiguration_get_cmap()prototype only once.Cc Bo Shen <[email protected]>Cc Simon Glass <[email protected]>Cc Anatolij Gustschin <[email protected]>Nikita Kiryanov (13):
lcd: move platform-specific structs to their own headers
lcd: splitconfiguration_get_cmap
lcd: atmel: move atmel-specificfb_put_wordtoatmel_lcdfb
lcd: mpc8xx: move mpc823-specificfb_put_bytetompc8xx_lcd.c
lcd: atmel: introducelcd_logo_set_cmap
lcd: mpc823: move mpc823-specificlcd_logo_set_cmapcode to
mpc8xx_lcd.c
lcd: logo: move generic cmap setting tolcd_logo_set_cmap()
lcd: introducelcd_set_cmap
lcd: remove unused includes
lcd: various cleanups
lcd: renamebitmap_plotto better represent its functionality
lcd: dt: extract simplefb support
lcd: split splash code into its own functionboard/raspberrypi/rpi/rpi.c | 1 + common/Makefile | 1 + common/lcd.c | 358 ++++++++++--------------------------------- common/lcd_simplefb.c | 59 +++++++ common/splash.c | 16 ++ drivers/video/atmel_hlcdfb.c | 13 ++ drivers/video/atmel_lcdfb.c | 51 ++++++ drivers/video/exynos_fb.c | 9 ++ drivers/video/mpc8xx_lcd.c | 29 ++++ drivers/video/pxa_lcd.c | 6 + include/atmel_lcd.h | 38 +++++ include/exynos_lcd.h | 81 ++++++++++ include/fdt_simplefb.h | 14 ++ include/lcd.h | 311 ++++++------------------------------- include/mpc823_lcd.h | 43 ++++++ include/pxa_lcd.h | 80 ++++++++++ include/splash.h | 11 +- 17 files changed, 574 insertions(+), 547 deletions(-)
Quoted 7 lines
create mode 100644
common/lcd_simplefb.c
create mode 100644include/atmel_lcd.h
create mode 100644include/exynos_lcd.h
create mode 100644include/fdt_simplefb.h
create mode 100644include/mpc823_lcd.h
create mode 100644include/pxa_lcd.h
For this whole series, I tested the Atmel lcd & hlcd part, you can add my tested-by:
Thanks.
Best Regards,
Josh Wu