Skip to content

Split SCSI header files

Bart Van Assche linux-scsi 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 9 repliesIn review
  2. v3 posting 2/24 patches 0 repliesSuperseded
  3. v3 posting 1/21 patch 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch2 repliesSuperseded
v11 patch4 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Split SCSI header filesinclude/scsi/scsi.h include/scsi/scsi_proto.h+283 -2702 replies
2/5Move code that is used both by initiator and target driversdrivers/scsi/Makefile drivers/scsi/scsi.c drivers/scsi/scsi_common.c +6 more+244 -2232 replies
3/5Replace MAX_COMMAND_SIZE with BLK_MAX_CDBdrivers/ata/libata-scsi.c drivers/block/cciss_scsi.c drivers/scsi/53c700.c +19 more+113 -1334 replies
4/5target: Correct a commentinclude/target/target_core_base.h+2 -101 reply
5/5target: Minimize SCSI header #include directivesDocumentation/target/tcm_mod_builder.py drivers/infiniband/ulp/srpt/ib_srpt.c drivers/infiniband/ulp/srpt/ib_srpt.h +33 more+32 -740 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigHannes Reinecke
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b R-b
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] Split SCSI header files

Move the constants and functions that are used by both initiator and target code to new header files such that the target code does no longer have to include initiator header files.

Changes in v4 of this series compared to v3:
- Split the first patch of this series into two patches as proposed by Christoph.

Changes in v3 of this series compared to v2:
- Renamed scsi_lib.h into scsi_common.h.
- Added a patch for replacing MAX_COMMAND_SIZE with BLK_MAX_CDB.
- Added a patch that minimizes the include directives in target code.

Changes in v2 of this series compared to v1:
- Dropped the scsi_lun.h header file and introduced scsi_lib.h.

The patches in this series are:
0001-Split-SCSI-header-files.patch 0002-Move-code-that-is-used-both-by-initiator-and-target-.patch 0003-Replace-MAX_COMMAND_SIZE-with-BLK_MAX_CDB.patch 0004-target-Correct-a-comment.patch 0005-target-Minimize-SCSI-header-include-directives.patch