USB: gadget: atmel_usba_udc: PM driver improvements
Get series with b4
b4 am [email protected]Versions newest first
- v7 Latest1 of 4 patches 0 repliesNew
1 of 4 patches is in this archive. The cover letter announces 4.
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 4/4 | USB: gadget: atmel_usba_udc: Add suspend/resume with wakeup support | +0 | 0 replies |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Nicolas Ferre |
|---|---|
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHv7 0/4] USB: gadget: atmel_usba_udc: PM driver improvements
Le 12/02/2015 18:54, Sylvain Rochet a ?crit :
Quoted 4 lines
Start clocks on rising edge of the Vbus signal, stop clocks on falling edge of the Vbus signal.
Add suspend/resume with wakeup support.
Hi Felipe,
I think this series by Sylvain is ready for inclusion. Are you able to take it for the next cycle?
Thank, bye,
Quoted 52 lines
Changes since v6:
* Removed single IRQ edge support, which was used to wake up only on device connection. We don't have yet a clean solution to handle IRQ controller with (at91sam9x5) and without (at91rm9200) single edge support. Rework PATCH v6 4/5 removed, we don't need this one anymore.Changes since v5:
* Some boards does not support configuring a GPIO interrupt on a specific edge (rising only or falling only). As suggested added a config boolean to distinguish between boards with and without support
* Added a missing mutex_lock()/unlock() inusba_udc_suspend(), we need to protectusba_stop()becauseusba_start()andusba_stop()can still be called by Vbus IRQ handler.
* Rebased the full series on linux-next
* Patch cleaning with the help of checkpatch.plChanges since v4:
* Now usingIRQ_NOAUTOENflag to remove the unused check forudc->driver is not NULL in the Vbus IRQ.* Reworked the start/stop of clocks on Vbus edges to prepare for suspend/resume support, factorised start and stop procedures
* New patch, suspend/resume for USBA with wakeup supportChanges since v3:
* Added stable tag for the first patch
* As suggested, removed the unused check forudc->driveris NULL inVbus IRQ by requesting IRQ after udc->driver is set and by releasing IRQ before udc->driver is cleared* Rebased the core patch of this series against the just explained changes
Changes since v2:
* Use spin_lock_irqsave/unlock_irqrestore instead of spin_lock/unlock in threaded interrupt because we are not in irq context anymore
* Removed useless and probably harmfulIRQF_NO_SUSPENDfromdevm_request_threaded_irq()flagsChanges since v1:
* Using a threaded irq and mutex instead of spinclock as suggested
* Moved a silently fixed bug in a separate patch (1/2)Sylvain Rochet (4):
USB: gadget:atmel_usba_udc: Fixedvbus_previnitial state
USB: gadget:atmel_usba_udc: Request an auto disabled Vbus signal IRQ
instead of an auto enabled IRQ request followed by IRQ disable
USB: gadget:atmel_usba_udc: Start clocks on rising edge of the Vbus
signal, stop clocks on falling edge of the Vbus signal
USB: gadget:atmel_usba_udc: Add suspend/resume with wakeup supportdrivers/usb/gadget/udc/atmel_usba_udc.c | 208 ++++++++++++++++++++++++-------- drivers/usb/gadget/udc/atmel_usba_udc.h | 4 + 2 files changed, 159 insertions(+), 53 deletions(-)
Signature · 1 line
Nicolas Ferre